Merge pull request #1041 from dvsa/features/scrollToBottom

feat: add scroll to bottom on ebsr
dvsa · Jan 10, 2025 · da45c2d · da45c2d
2 parents 1cab522 + 4594321
commit da45c2d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/test/java/org/dvsa/testing/framework/pageObjects/BasePage.java b/src/test/java/org/dvsa/testing/framework/pageObjects/BasePage.java
@@ -671,9 +671,12 @@ public static String getSelectedTextFromDropDown(@NotNull String selector, @NotN
         return option.getFirstSelectedOption().getText();
     }
 
-    public static void scrollToBottom() {
-        JavascriptExecutor js = (JavascriptExecutor) getDriver();
-        js.executeScript("window.scrollTo(0, document.body.scrollHeight)");
+    public void scrollToBottom() {
+        WebElement footer = getDriver().findElement(By.tagName("govuk-footer"));
+        int deltaY = footer.getRect().y;
+        new Actions(getDriver())
+                .scrollByAmount(0, deltaY)
+                .perform();
     }
 
     public boolean pageContains(String text) {

diff --git a/src/test/java/org/dvsa/testing/framework/stepdefs/vol/EBSRUpload.java b/src/test/java/org/dvsa/testing/framework/stepdefs/vol/EBSRUpload.java
@@ -90,6 +90,7 @@ public void documentsAreGenerated() throws IllegalBrowserException, IOException
 
             } while ((long) findElements("//*[@class='field file-upload']", SelectorType.XPATH).size() < 2 && System.currentTimeMillis() < kickOutTime);
             try {
+                scrollToBottom();
                 assertTrue(findElements("//*[@class='field file-upload']", SelectorType.XPATH).stream().anyMatch(
                         webElement -> webElement.getText().contains("Route Track Map PDF (Auto Scale)")));
             } catch (Exception e) {