-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5910 - updated dev job schedules #561
base: main
Are you sure you want to change the base?
Conversation
timeout = 43200, | ||
schedule = "cron(30 06 * * ? *)", | ||
}, | ||
# Environment is not up at this time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not keen on a load of commented out sections - if we don't need them remove them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, left them there for someone to review
}, | ||
# Environment is not up at this time | ||
# { | ||
# name = "clean-up-variations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these jobs not need to continue to run, just concerned that we don't currently have dedicated test cases for this so ideally they all need to run.
Related issue: https://dvsa.atlassian.net/browse/VOL-5910
Before submitting (or marking as "ready for review")