Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5910 - updated dev job schedules #561

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Wi11Shell
Copy link
Contributor

Related issue: https://dvsa.atlassian.net/browse/VOL-5910

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@Wi11Shell Wi11Shell requested a review from a team as a code owner January 20, 2025 14:19
fibble
fibble previously approved these changes Jan 20, 2025
timeout = 43200,
schedule = "cron(30 06 * * ? *)",
},
# Environment is not up at this time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not keen on a load of commented out sections - if we don't need them remove them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, left them there for someone to review

},
# Environment is not up at this time
# {
# name = "clean-up-variations",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these jobs not need to continue to run, just concerned that we don't currently have dedicated test cases for this so ideally they all need to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants