chore(cb2-11271): aws sdk upgrade - resolving issue post update (#404)

* feat(cb2-11271): change to marshall options and error

* feat(cb2-11271): fix failing test

* feat(cb2-11271): fix lint

* feat(cb2-11271): add log)

* feat(cb2-11271): linting fixes

* feat(cb2-11271): removes console log

* feat(cb2-11271): remove undefined values

* feat(cb2-11271): remove undefined values

src/handlers/VehicleTestController.ts

@@ -1,16 +1,15 @@
-import { cloneDeep, mergeWith, differenceWith, isEqual } from 'lodash';
-import { EPROTONOSUPPORT } from 'constants';
+import { cloneDeep, differenceWith, isEqual, mergeWith } from 'lodash';
 import * as enums from '../assets/Enums';
-import * as utils from '../utils';
 import * as models from '../models';
-import { IVehicleTestController } from './IVehicleTestController';
-import { IExpiryDateStrategy } from './expiry/IExpiryDateStrategy';
-import { ExpiryDateStrategyFactory } from './expiry/ExpiryDateStrategyFactory';
+import { TestType } from '../models';
 import { TestTypeForExpiry } from '../models/TestTypeforExpiry';
 import { Service } from '../models/injector/ServiceDecorator';
-import { TestDataProvider } from './expiry/providers/TestDataProvider';
+import * as utils from '../utils';
+import { IVehicleTestController } from './IVehicleTestController';
+import { ExpiryDateStrategyFactory } from './expiry/ExpiryDateStrategyFactory';
+import { IExpiryDateStrategy } from './expiry/IExpiryDateStrategy';
 import { DateProvider } from './expiry/providers/DateProvider';
-import { TestType } from '../models';
+import { TestDataProvider } from './expiry/providers/TestDataProvider';
 
 @Service()
 export class VehicleTestController implements IVehicleTestController {

src/handlers/expiry/providers/TestDataProvider.ts

@@ -1,6 +1,7 @@
-import { Service } from '../../../models/injector/ServiceDecorator';
+import { ConditionalCheckFailedException } from '@aws-sdk/client-dynamodb';
 import * as enums from '../../../assets/Enums';
 import * as models from '../../../models';
+import { Service } from '../../../models/injector/ServiceDecorator';
 import * as utils from '../../../utils';
 import { DateProvider } from './DateProvider';
 import { ITestDataProvider } from './ITestDataProvider';
@@ -241,6 +242,12 @@ export class TestDataProvider implements ITestDataProvider {
       return result.Attributes as models.ITestResult[];
     } catch (error) {
       console.error('TestDataProvider.insertTestResult -> ', error);
+      if (
+        error instanceof ConditionalCheckFailedException &&
+        error.$response?.statusCode
+      ) {
+        throw new models.HTTPError(error.$response?.statusCode, error.message);
+      }
       throw error;
     }
   }

src/models/TestResultsDAO.ts

@@ -26,7 +26,10 @@ export class TestResultsDAO {
   constructor() {
     const config = Configuration.getInstance().getDynamoDBConfig();
     const translateConfig = {
-      marshallOptions: { removeUndefinedValues: true },
+      marshallOptions: {
+        convertEmptyValues: true,
+        removeUndefinedValues: true,
+      },
     };
 
     this.tableName = config.table;