Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB2-3295: EVL Feed Endpoint #14

Merged
merged 21 commits into from
Jun 23, 2022
Merged

CB2-3295: EVL Feed Endpoint #14

merged 21 commits into from
Jun 23, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2022 •
edited by ghost
Loading

This should not be merged until develop is ready.

The changes contain the following steps:

  1. query the top database for the eve feed data from the new view
  2. format this data into a new type
  3. save that to a csv file as described in part by the atom documentation

Checklist

  • Code has been tested manually
  • PR title includes the JIRA ticket number
  • Branch is rebased against the latest develop
  • Squashed commit contains the JIRA ticket number

Aaron Downing and others added 18 commits May 26, 2022 15:17
feat(cb2-3295): create new evl feed endpoint and sql view queries
366fbc8
feat(cb2-3295): added IO service and fixed linting
b18bfa6
feat(cb2-3295): fixed merge conflicts
d612ba6
Merge branch 'develop' into feature/CB2-3185
9501932
feat(cb2-3295): added data mapping and cvs file gen
84f5be8
feat(cb2-3295): added unit tests and Start of S3 upload
01a7e10
feat(cb2-3295): added param for S3 and created remove file function
4441a5c
refactor(cb2-3295): added more logs and error messages
d49b8e0
refactor(cb2-3295): added more logs and error messages
8c83672
refactor(cb2-3295): added remove to s3 upload callback
b6b1ef5
refactor(cb2-3295): added remove to s3 upload callback
efbcb07
refactor(cb2-3295): added remove to s3 upload callback
b8a210e
refactor(cb2-3295): added read write to /tmp
74a5ae9
feat(cb2-3295): add unit tests for evlFeedQueryFunctionFactory
d6014ac
refactor(cb2-3295): refactored s3 implementation and added s3 local
2fff90d
refactor(cb2-3295): remove code from index
d814211
refactor(cb2-3295): added response sent to callback on s3 upload
8a2862f
feat(cb2-3295): bumped test coverage back up
69f9427
ghost
ghost commented Jun 17, 2022
View reviewed changes
package.json Show resolved Hide resolved
Ian-Hodges
Ian-Hodges reviewed Jun 17, 2022
View reviewed changes
commitlint.config.js Outdated Show resolved Hide resolved
@aaron-downing aaron-downing marked this pull request as ready for review June 22, 2022 13:23
naathanbrown
naathanbrown previously approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@naathanbrown naathanbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, we could maybe look at increasing the logging we have on this and using something like the logging level found on the push file lambda but not necessary.

@Ian-Hodges Ian-Hodges requested a review from naathanbrown June 23, 2022 10:02
@aaron-downing aaron-downing merged commit 3dd056e into develop Jun 23, 2022
@cvs-ops cvs-ops deleted the feature/CB2-3185 branch October 10, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ian-Hodges @naathanbrown @aaron-downing