-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
d6e46f5
commit 406c050
Showing
226 changed files
with
4,001 additions
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
name: 🧱 Build and Test | ||
run-name: 🧱 Build and Test ${{ github.ref_name }} | ||
on: | ||
push: | ||
paths: | ||
- 'application/**' | ||
workflow_call: | ||
workflow_dispatch: | ||
inputs: | ||
ignore-test-failures: | ||
type: boolean | ||
description: Ignore Test Failures | ||
default: false | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref_name }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
environment: | ||
name: 🧹 Prepare Environment | ||
runs-on: ubuntu-latest | ||
outputs: | ||
environment-name: ${{ steps.environment.outputs.environment-name }} | ||
environment-type: ${{ steps.environment.outputs.environment-type }} | ||
github-branch: ${{ steps.environment.outputs.github-branch }} | ||
commit: ${{ steps.commit.outputs.commit }} | ||
package-name: ${{ steps.name.outputs.package-name }} | ||
|
||
steps: | ||
- name: Generate Package Name | ||
id: name | ||
run: | | ||
repo=${{ github.repository }} | ||
echo "package-name=${repo#dvsa/}" >> $GITHUB_OUTPUT | ||
echo "Package Name: ${repo#dvsa/}" >> $GITHUB_STEP_SUMMARY | ||
- name: 📥 Get Codebase | ||
uses: actions/checkout@v4 | ||
with: | ||
ref: ${{ github.ref_name }} | ||
|
||
- name: ↕️ Get Environment Details | ||
id: environment | ||
uses: dvsa/cvs-github-actions/environment@develop | ||
with: | ||
environment: ${{ github.ref_name }} | ||
|
||
- name: Get Commit SHA | ||
id: commit | ||
run: | | ||
# Get the branch Commit ID | ||
commit_id=$(git rev-parse HEAD) | ||
echo "commit=${commit_id}" | ||
echo "commit=${commit_id}" >> $GITHUB_OUTPUT | ||
echo "Commit ID: ${commit_id}" >> $GITHUB_STEP_SUMMARY | ||
build-service: | ||
name: 🧱 Build ${{ needs.environment.outputs.package-name }} | ||
runs-on: ubuntu-latest | ||
environment: ${{ needs.environment.outputs.environment-type }} | ||
needs: environment | ||
steps: | ||
- name: 📥 Get Codebase | ||
uses: actions/checkout@v4 | ||
|
||
- name: 🗒️ Process Manifest Data | ||
id: manifest | ||
run: | | ||
# Generate Manifest Outputs & Identify Build Requirements | ||
hash_files="[]" | ||
if [[ -f "manifest.json" ]]; then | ||
package=$(jq -r '.name' manifest.json) | ||
echo "package=$(jq -r '.name' manifest.json)" >> $GITHUB_OUTPUT | ||
echo "language=$(jq -r '.language' manifest.json)" >> $GITHUB_OUTPUT | ||
echo "liquibase=$(jq -r '.liquibase' manifest.json)" >> $GITHUB_OUTPUT | ||
fi | ||
- name: 🏗️ Build Node Function | ||
uses: dvsa/cvs-github-actions/build-node-function@develop | ||
with: | ||
commit-sha: ${{ needs.environment.outputs.commit }} | ||
branch: ${{needs.environment.outputs.github-branch }} | ||
mysql_liquibase: ${{ steps.manifest.outputs.liquibase }} | ||
mysql_user: ${{ secrets.MYSQL_USER }} | ||
mysql_password: ${{ secrets.MYSQL_PASS }} | ||
continue-on-error: ${{ inputs.ignore-test-failures }} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
MIT License | ||
|
||
Copyright (c) 2021 Driver & Vehicle Standards Agency | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,167 @@ | ||
# cvs-svc-enquiry | ||
|
||
Lambda service to retrieve vehicle and test information for commerical vehicles | ||
|
||
## Dependencies | ||
|
||
The project runs on node 18.x with typescript and serverless framework. For further details about project dependencies, please refer to the `package.json` file. | ||
[nvm](https://github.com/nvm-sh/nvm/blob/master/README.md) is used to managed node versions and configuration explicitely done per project using an `.npmrc` file. | ||
|
||
## Running the project | ||
|
||
Once the dependencies are installed, you will be required to rename the `/config/env.example` file to `.env.local` as we use dotenv files for configuration for local local development for example. Further information about [variables](https://www.serverless.com/framework/docs/providers/aws/guide/variables/) and [environment variables](https://www.serverless.com/framework/docs/environment-variables/) with serverless. | ||
|
||
The application runs on port `:3001` by default when no stage is provided. | ||
|
||
Serverless is used for local development, to get started after running `nvm use && npm i`. | ||
You will need to initialize the external dependencies loaded as submodules, please refer to the [External dependencies](#external-dependencies) section. | ||
Once the SQL database has been populated with liquibase, you can run `npm run start:dev`. | ||
|
||
Docker container might fail to boot, should it happen, delete the Docker container and rerun the `start:dev` script. | ||
|
||
### Environments | ||
|
||
We use `NODE_ENV` environment variable to set multi-stage builds (region, stages) with the help of dotenv through npm scripts to load the relevant `.env.<NODE_ENV>` file from `./config` folder into the `serverless.yml` file as we don't rely on serverless for deployment. | ||
If no `NODE_ENV` value is provided when running the scripts, it will default its `NODE_ENV` value to 'development' with the `.env.development` config file. | ||
|
||
The defaulted values for 'stage' and 'region' are `'local'`. Please refer to the values provided in the `serverless.yml` file. | ||
|
||
The following values can be provided when running the scripts with `NODE_ENV`: | ||
|
||
```ts | ||
// ./config/.env.<NODE_ENV> files | ||
'local'; // used for local development | ||
'development'; // used development staging should we wish to require external services | ||
'test'; // used during test scripts where local services, mocks can be used in conjonction | ||
``` | ||
|
||
```ts | ||
/** Running serverless offline as an example for a specific stage - 'local'. | ||
* Stage 'local' will be injected in the serverless.yml | ||
**/ | ||
NODE_ENV=local serverless offline | ||
|
||
``` | ||
|
||
Further details about environment setup can be found in the provided documentation and `env.example` file. | ||
|
||
All secrets the secrets are will stored in `AWS Secrets Manager`. | ||
|
||
### Scripts | ||
|
||
The following scripts are available, for further information please refer to the project `package.json` file: | ||
|
||
- <b>start</b>: `npm start` - _launch serverless offline service_ | ||
- <b>start:dev</b>: `npm run start:dev` - _launch serverless offline service with dockerised DB_ | ||
- <b>dev</b>: `npm run dev` - _run in parallel the service and unit tests in_ `--watch` _mode with live reload_. | ||
- <b>test</b>: `npm t` - _execute the unit test suite_ | ||
- <b>build</b>: `npm run build` - _bundle the project for production_ | ||
|
||
### Local database | ||
|
||
The project needs a database available in order to run locally. The `npm run start:dev` command, and by extension `npm run dev` as well, will automatically set up a database running in a docker container in the background for you and populate it with sample data. The connection details for viewing the database can be found in `src/infrastructure/localSecretsManagerService.ts`. Running `npm run start:dev` repeatedly will only initialise a single docker container, and your changes to the database will only be removed if you delete the container. | ||
For more information about the Docker cli, please refer to the [documentation](https://docs.docker.com/engine/reference/commandline/cli/). | ||
|
||
### Offline | ||
|
||
Serverless-offline with webpack is used to run the project locally. Please use `npm run dev` script to do so. Go to `http://localhost:3001/local/version` to confirm that everything has loaded correctly, you should see that the version is the same as the version in the `package.json` | ||
|
||
### Lambda locally | ||
|
||
Serverless can invoke lambda functions locally which provide a close experience to the real service if you decide not use the offline mode. `events` and `paths` can be found under `/local` folder. | ||
For further details using lambda locally please refer to the [serverless documentation](https://www.serverless.com/framework/docs/providers/aws/cli-reference/invoke-local/). | ||
|
||
### Debugging | ||
|
||
Existing configuration to debug the running service has been made available for vscode, please refer to `.vscode/launch.json` file. Serverless offline will be available on port `:4000`. 2 jest configurations are also provided which will allow to run a test or multiple tests. | ||
|
||
For further information about debugging, please refer to the following documentation: | ||
|
||
- [Run-a-function-locally-on-source-changes](https://github.com/serverless-heaven/serverless-webpack#run-a-function-locally-on-source-changes) | ||
|
||
- [VSCode debugging](https://github.com/serverless-heaven/serverless-webpack#vscode-debugging) | ||
|
||
- [Debug process section](https://www.serverless.com/plugins/serverless-offline#usage-with-webpack) | ||
|
||
### Unit | ||
|
||
Jest is used for unit testing. | ||
Please refer to the [Jest documentation](https://jestjs.io/docs/en/getting-started) for further details. | ||
|
||
### Integration | ||
|
||
To be added and customised depending on needs, supertest is used but we could be looking at other packages such as nock, ts-mockito, typemoq, wiremock, etc.. or testing (pactjs, hoverfly, mockserver, etc..) | ||
|
||
## Infrastructure | ||
|
||
<Insert Design> | ||
|
||
### Release | ||
|
||
Releases (tag, release notes, changelog, github release, assets) are automatically managed by [semantic-release](https://semantic-release.gitbook.io/semantic-release/) and when pushing (or merging) to `master` branch which is protected. [semver](https://semver.org/) convention is followed. | ||
|
||
Please be familiar with conventional commit as described in the Contributing section below. | ||
|
||
Default preset used is angular for conventional commits, please see the [angular conventions](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional#type-enum). | ||
|
||
The `<type>` `'breaking'` in the commit message will trigger a major version bump as well as any of the following text contained in the commit body: `"BREAKING CHANGE", "BREAKING CHANGES", "BREAKING_CHANGES", "BREAKING", "BREAKING_CHANGE"`. Please refer to the `.releaserc.json` file for the full configuration. | ||
|
||
The script `npm run release` will automatically trigger the release in CI. To manually test the release the following flags -`--dry-run --no-ci` - can be passed to the release script. | ||
|
||
Publishing and artifacts are managed separately by the pipeline. | ||
|
||
## Contributing | ||
|
||
To facilitate the standardisation of the code, a few helpers and tools have been adopted for this repository. | ||
|
||
### External dependencies | ||
|
||
The project depends on the cvs-nop repository as a git module. Use `--recurse-submodules` when cloning the project to automatically set up the submodule, or use `git submodule init` followed by `git submodule update` to pull the submodule in if you already have the project checked out. | ||
|
||
The projects has multiple hooks configured using [husky](https://github.com/typicode/husky#readme) which will execute the following scripts: `audit`, `lint`, `build`, `test` and format your code with [eslint](https://github.com/typescript-eslint/typescript-eslint#readme) and [prettier](https://github.com/prettier/prettier). | ||
|
||
You will be required to install [git-secrets](https://github.com/awslabs/git-secrets) (_brew approach is recommended_) and DVSA [repo-security-scanner](https://github.com/UKHomeOffice/repo-security-scanner) that runs against your git log history to find accidentally committed passwords, private keys. | ||
|
||
We follow the [conventional commit format](https://www.conventionalcommits.org/en/v1.0.0/) when we commit code to the repository and follow the [angular convention](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional#type-enum). | ||
|
||
The type is mandatory and must be all lowercase. | ||
The scope of your commit remain is also mandatory, it must include your ticket number and be all lowercase. The format for the ticket number can be set in the commitlint.config.js file. | ||
|
||
```js | ||
// Please see /commitlint.config.js for customised format | ||
|
||
type(scope?): subject | ||
|
||
// examples | ||
'chore(cvsb-1234): my commit msg' // pass | ||
'CHORE(cvsb-1234): my commit msg' // will fail | ||
|
||
``` | ||
### Code standards | ||
#### Code structure | ||
Domain Drive Design diagram with Interfaces, Application, Domain layers and Infrastructure across the layers. | ||
<p align="center"> | ||
<img src="./docs/DDD_architecture.jpg" alt="Domain Drive Design diagram with Interfaces, Application, Domain layers and Infrastructure across the layers" > | ||
</p> | ||
Please refer to the the [docs](./docs/README.md) for the API specification and samples of postman requests. | ||
#### Toolings | ||
The code uses [eslint](https://eslint.org/docs/user-guide/getting-started), [typescript clean code standards](https://github.com/labs42io/clean-code-typescript) as well as sonarqube for static analysis. | ||
SonarQube is available locally, please follow the instructions below if you wish to run the service locally (brew is the preferred approach): | ||
- _Brew_: | ||
- Install sonarqube using brew | ||
- Change `sonar.host.url` to point to localhost, by default, sonar runs on `http://localhost:9000` | ||
- run the sonar server `sonar start`, then perform your analysis `npm run sonar-scanner` | ||
|
||
- _Manual_: | ||
- Add sonar-scanner in environment variables in your \_profile file add the line: `export PATH=<PATH_TO_SONAR_SCANNER>/sonar-scanner-3.3.0.1492-macosx/bin:$PATH` | ||
- Start the SonarQube server: `cd <PATH_TO_SONARQUBE_SERVER>/bin/macosx-universal-64 ./sonar.sh start` | ||
- In the microservice folder run the command: `npm run sonar-scanner` |
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Empty file.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Submodule cvs-nop
deleted from
39b9c8
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
latest:^1.8 |
Oops, something went wrong.