-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docs page #399
feat: add docs page #399
Conversation
Reviewer's Guide by SourceryThis PR adds a new documentation site using Nextra (a Next.js-based documentation framework) and sets up GitHub Actions workflow for building and deploying the docs to GitHub Pages. The implementation includes the basic Next.js configuration, theme setup, and GitHub Actions workflow for automated deployment. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 100 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using Node.js LTS version (currently 20.x) instead of version 22 which is unstable/in development
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage 78.34% 78.34%
=======================================
Files 5 5
Lines 157 157
Branches 58 57 -1
=======================================
Hits 123 123
- Misses 31 34 +3
+ Partials 3 0 -3 ☔ View full report in Codecov by Sentry. |
a58387d
to
0dc46bc
Compare
0dc46bc
to
9079b72
Compare
9079b72
to
ab5f873
Compare
ab5f873
to
05b0f2e
Compare
05b0f2e
to
a84b9f1
Compare
a84b9f1
to
12e11f7
Compare
Summary by Sourcery
Add a new documentation page for ClickHouse Monitoring using Nextra and Next.js, and set up a GitHub Actions workflow to automate the build and deployment process to GitHub Pages.
New Features:
CI: