-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update charts /failed-queries, fix CodeDialog #397
Conversation
Reviewer's Guide by SourceryThis PR updates the failed queries charts configuration and improves the CodeDialog component's accessibility and styling. The changes primarily focus on adjusting time ranges for failed query visualizations and enhancing the code display dialog's user interface. Updated class diagram for CodeDialogFormat componentclassDiagram
class CodeDialogFormat {
+value
+options
+DialogTrigger
+DialogContent
+DialogHeader
+DialogTitle
+DialogDescription
+content
}
note for CodeDialogFormat "Updated to include VisuallyHidden.Root for accessibility and improved styling for code display."
Updated class diagram for failedQueriesConfigclassDiagram
class failedQueriesConfig {
+failed-query-count
+failed-query-count-by-user
+title: String
+interval: String
+lastHours: Number
+showLegend: Boolean
}
note for failedQueriesConfig "Updated time ranges and titles for failed query visualizations."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Bundle ReportChanges will increase total bundle size by 379 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 78.34% 78.34%
=======================================
Files 5 5
Lines 157 157
Branches 58 58
=======================================
Hits 123 123
Misses 34 34 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Update the failed queries chart configuration to show data for the last 7 days and add a new chart for the last 24 hours. Fix the CodeDialog component to correctly handle dialog titles and descriptions. Add the @radix-ui/react-visually-hidden package to the project dependencies.
Bug Fixes:
Enhancements:
Chores: