Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: count-across-replicas link to table detail, <ErrorAlert /> add toggle to open detailed query, add number chart #314

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

duyet
Copy link
Owner

@duyet duyet commented Jul 23, 2024

Summary by Sourcery

This pull request introduces a new NumberChart component, enhances the ErrorAlert component with an accordion for detailed query views, and updates the count-across-replicas page to link database tables to their detailed views. Additionally, it includes updates to the TableSkeleton component for better width flexibility and adds corresponding tests for the new features.

  • New Features:
    • Introduced a new NumberChart component for displaying numerical data in a chart format.
  • Enhancements:
    • Updated ErrorAlert component to include an accordion for viewing detailed query information.
    • Modified the count-across-replicas page to link database tables to their detailed views.
    • Enhanced the TableSkeleton component to have a more flexible width.
  • Tests:
    • Added tests for the new accordion feature in the ErrorAlert component.
    • Updated tests for the LinkFormat component to reflect the new URL structure.

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clickhouse-monitoring ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 9:10am

Copy link
Contributor

sourcery-ai bot commented Jul 23, 2024

Reviewer's Guide by Sourcery

This pull request introduces several enhancements and fixes across multiple components and pages. Key changes include extending the countdown timer in the ErrorAlert component, adding an accordion to display detailed query information, updating SQL queries and column formats to link to table details, and adding a new NumberChart component. Additionally, test cases have been updated to reflect these changes.

File-Level Changes

Files Changes
app/clusters/[cluster]/count-across-replicas/page.tsx
app/[query]/tables/replicas.ts
components/data-table/cells/link-format.cy.tsx
components/data-table/cells/link-format.tsx
Updated SQL queries and column formats to link to table details, ensuring consistency across the application.
components/error-alert.tsx
components/error-alert.cy.tsx
Enhanced ErrorAlert component with a longer countdown timer and an accordion for detailed query information, along with corresponding test cases.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@duyet duyet merged commit 990fe58 into main Jul 23, 2024
15 checks passed
@duyet duyet deleted the chore/ui branch July 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant