Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add number formatting option to BackgroundBarFormat #306

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

duyet
Copy link
Owner

@duyet duyet commented Jul 22, 2024

Summary by Sourcery

This pull request introduces a new number formatting option to the BackgroundBarFormat component, enhancing the readability of displayed values. It also updates the top-usage-columns configuration to utilize this new feature. Additionally, the caching strategy in GitHub Actions workflows has been improved by adding more cache paths for Yarn and Next.js.

  • New Features:
    • Added a number formatting option to the BackgroundBarFormat component, allowing values to be displayed in a more readable format.
  • Enhancements:
    • Updated the top-usage-columns configuration to use the new number formatting option for the count column.
  • CI:
    • Enhanced the caching strategy in GitHub Actions workflows by including additional cache paths for Yarn and Next.js.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clickhouse-monitoring ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:01am

Copy link
Contributor

sourcery-ai bot commented Jul 22, 2024

Reviewer's Guide by Sourcery

This pull request introduces a number formatting option to the BackgroundBarFormat component. The changes include updates to the component's props, the addition of a new interface for options, and modifications to the rendering logic to support the new formatting option. Additionally, the GitHub workflows have been updated to include additional cache directories and rename a cache step.

File-Level Changes

Files Changes
.github/workflows/test.yml
.github/workflows/base.yml
Updated Yarn Cache paths to include additional directories and renamed a cache step.
components/data-table/cells/background-bar-format.tsx
app/[query]/more/top-usage-columns.ts
components/data-table/format-cell.tsx
types/column-format.ts
Added number formatting option to BackgroundBarFormat and updated related components and types.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @duyet - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/test.yml Show resolved Hide resolved
components/data-table/format-cell.tsx Show resolved Hide resolved
@duyet duyet merged commit 5a95280 into main Jul 22, 2024
25 checks passed
@duyet duyet deleted the chore/ui branch July 22, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant