Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add turbo #277

Merged
merged 2 commits into from
Jun 30, 2024
Merged

chore(ci): add turbo #277

merged 2 commits into from
Jun 30, 2024

Conversation

duyet
Copy link
Owner

@duyet duyet commented Jun 30, 2024

Summary by Sourcery

This pull request introduces a turbo.json configuration file to streamline CI tasks, including build, lint, format, and test operations.

  • CI:
    • Added turbo.json configuration file to define tasks for build, lint, format, and test.

Copy link

vercel bot commented Jun 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clickhouse-monitoring ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 2:40am

Copy link
Contributor

sourcery-ai bot commented Jun 30, 2024

Reviewer's Guide by Sourcery

This pull request adds a new configuration file for Turbo, a build system. The changes involve the creation of a turbo.json file that defines tasks for building, linting, formatting, and testing the project.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @duyet - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

{
"$schema": "https://turbo.build/schema.json",
"tasks": {
"build": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider adding a description for the build task.

Adding a description for the build task can help other developers understand its purpose and any specific configurations it might have.

Suggested change
"build": {
"build": {
"description": "Builds the project, excluding the cache directory.",

},
"lint": {},
"fmt": {},
"test": {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (testing): Consider specifying test configurations or scripts.

Providing specific test configurations or scripts can help ensure that tests are run consistently and correctly.

Suggested change
"test": {}
"test": {
"scripts": {
"unit": "jest --config jest.config.js",
"integration": "jest --config jest.integration.config.js"
}
}

@duyet duyet merged commit 5b1659e into main Jun 30, 2024
12 checks passed
@duyet duyet deleted the chore/ui branch June 30, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant