-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add turbo #277
chore(ci): add turbo #277
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request adds a new configuration file for Turbo, a build system. The changes involve the creation of a Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
{ | ||
"$schema": "https://turbo.build/schema.json", | ||
"tasks": { | ||
"build": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider adding a description for the build task.
Adding a description for the build task can help other developers understand its purpose and any specific configurations it might have.
"build": { | |
"build": { | |
"description": "Builds the project, excluding the cache directory.", |
}, | ||
"lint": {}, | ||
"fmt": {}, | ||
"test": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): Consider specifying test configurations or scripts.
Providing specific test configurations or scripts can help ensure that tests are run consistently and correctly.
"test": {} | |
"test": { | |
"scripts": { | |
"unit": "jest --config jest.config.js", | |
"integration": "jest --config jest.integration.config.js" | |
} | |
} |
Summary by Sourcery
This pull request introduces a turbo.json configuration file to streamline CI tasks, including build, lint, format, and test operations.