feat: add zookeeper-wait chart #240
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Hey @duyet - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| import { BarChart } from '../tremor/bar' | ||
| import { type ChartProps } from './chart-props' | ||
|
|
||
| export async function ChartZookeeperWait({ |
There was a problem hiding this comment.
suggestion: Function name should be in camelCase
The function name 'ChartZookeeperWait' should be in camelCase to follow JavaScript naming conventions. Consider renaming it to 'chartZookeeperWait'.
| export async function ChartZookeeperWait({ | |
| export async function chartZookeeperWait({ |
| lastHours = 24 * 7, | ||
| className, | ||
| }: ChartProps) { | ||
| const query = ` |
There was a problem hiding this comment.
🚨 issue (security): Potential SQL injection risk
Using template literals for SQL queries can introduce SQL injection risks. Consider using parameterized queries to mitigate this risk.
| categories={['AVG_ProfileEvent_ZooKeeperWaitSeconds']} | ||
| readableColumn="readable_AVG_ProfileEvent_ZooKeeperWaitSeconds" | ||
| className="h-52" | ||
| stack |
There was a problem hiding this comment.
question: Clarify the purpose of 'stack' prop
The 'stack' prop is used here without any context. Consider adding a comment or documentation to explain its purpose and how it affects the BarChart component.
No description provided.