Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upcoming source_provider plugin hook #8

Merged
merged 2 commits into from
Aug 5, 2015
Merged

Add support for upcoming source_provider plugin hook #8

merged 2 commits into from
Aug 5, 2015

Conversation

amorde
Copy link
Contributor

@amorde amorde commented Jul 9, 2015

Here's an initial implementation that supports the yet-to-be-completed plugin source_provider hook as described in CocoaPods/CocoaPods#3792

Some tests should probably be made for the new functionality, but for now I have successfully tested it on my machine using my branch of cocoapods that includes the new plugin hook.

Example:

plugin 'cocoapods-repo-svn', {
    :sources => [
        "https://svn.myrepo.com/private-specs"
    ]
}
$ pod install
Updating spec repo `private-specs`
Updating '.':
At revision 12345.
Analyzing dependencies
Downloading dependencies
...

About the SVN executable & backticks.. I kept getting errors such as "Unknown subcommand: 'up --non-interactive --trust-server-cert'" from svn when using the svn!('up --non-interactive --trust-server-cert') syntax.

Let me know what you think!

@dustywusty
Copy link
Owner

This looks great @amorde!

Waiting on CocoaPods/CocoaPods#3792 to be merged

🍰 🍬 🍰

@amorde
Copy link
Contributor Author

amorde commented Jul 14, 2015

Awesome!

@eseilnacht
Copy link

+1

dustywusty added a commit that referenced this pull request Aug 5, 2015
Add support for upcoming source_provider plugin hook
@dustywusty dustywusty merged commit 5519a00 into dustywusty:master Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants