Update non_field_errors object to follow spec #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This looks good. Going to try it out before merging. /cc @holandes22 |
| }); | ||
| } else { | ||
| out.push({ | ||
| source: { pointer: `data/attributes/${key}`}, | ||
| source: { pointer: `data/attributes/${key}` }, |
There was a problem hiding this comment.
Ember Data 1.13.7 (released yesterday) "fixed" the pointer format to align with the JSON API spec.
I think you'll need to add a forward slash to the beginning here (and on line 125), and update the documentation to show compatibility with ED >= 1.13.7
There was a problem hiding this comment.
@dustinfarris yeah you're right about that. Update coming up in a few minutes.
|
@dustinfarris updated for ember-data 1.13.7 |
|
This is working, but ED doesn't seem to do anything with the /data errors. Going to merge this and open an issue there. |
dustinfarris
added a commit
that referenced
this pull request
Jul 28, 2015
Update non_field_errors object to follow spec
|
Opened emberjs/data#3602 |
|
@dustinfarris awesome, thanks. Subscribed over to that issue for any follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went ahead and worked on fixing #113 based on the previous discussion.