Update to ember 1.13 serializer api.

[benkonrath]

I still need to update the documentation.

There is one remaining deprecation warning but it is an application level warning so I don't think we should override this function in EDA.

DEPRECATION: The default behavior of shouldReloadAll will change in Ember Data 2.0 to always return false when there is at least one "post" record in the store. If you would like to preserve the current behavior please override shouldReloadAll in your adapter:application and return true.

closes #110
closes #111

[benkonrath]

I'll work on updating the docs tomorrow morning.

[holandes22]

@benkonrath we currently do not test against the canary ember-data version in CI
You can enable that by changing the line in package.json:
"test": "ember try ember-data-stable" with `"test": "ember try:testall"

[holandes22]

@benkonrath oops, nvm my last comment, see you did that already :)

[benkonrath]

@holandes22 I have 2 test cases: ED 1.13.5 / E 1.12.1 and ED 1.13.5 / E 1.13.4. I didn't think it made sense to test against canary for our 1.0 release.

[holandes22]

I mentioned it since the changes you are making should make it work with the next version of ember-data (2.0). I think I made a mistake and called it canary and it is actually Beta.

Anyway, my idea was to also test against 2.0 as it should work with your modifications

[benkonrath]

@holandes22 The tests didn't pass with ember data and ember beta so I haven't included it in the test matrix.

[benkonrath]

Some notes on this update:

• DRFSerializer now sub-classes JSONSerializer (as per ED suggestion for non-JSON API / legacy APIs)
• Overriding metadata in extractMeta has changed
• I removed the ember-cli-pagination instructions as that library doesn't seem to be maintained any more (it might still work though - I don't know off hand). I have wrote my own pagination compontent that I could contribute to this project if you guys think it fits.

[dustinfarris]

Embedded records seems to be broken.

[benkonrath]

Ok, I guess we should add a test for that. I'll check it out tomorrow.

[dustinfarris]

Looks like a bug in ED emberjs/data#3549

[benkonrath]

Thanks for finding that. I guess we have to wait for a new release before we can get this merged in.

[dustinfarris]

Yeah. Looks like a fix was merged yesterday: emberjs/data#3550

Just need a point release.

[dustinfarris]

ED 1.13.6 is out and it looks like it has the bugfix we need

[benkonrath]

I can't grab it with bower yet. I'll update to ED 1.13.6 once I can.

[jpadilla]

@benkonrath seems have been updated a couple of minutes ago.

https://github.com/components/ember-data

[benkonrath]

@jpadilla Thanks! I've updated the PR.

[benkonrath]

I'm having problems with the embedded records still. I'll investigate in a bit. I've updated the tests to expose the problem.

[benkonrath]

I made a mistake in the test. But the embedded record for belongsTo retrieve still isn't working in my app with this PR.

[benkonrath]

I get this message in my app when trying to load a belongsTo embedded record:

Uncaught Error: Assertion Failed: You looked up the 'post' relationship on a 'comment' with id 2964 but some of the associated records were not loaded. Either make sure they are all loaded together with the parent record, or specify that the relationship is async (`DS.belongsTo({ async: true })`)

Everything is setup just like the test case. If I change to async: true, it tries to load the records with a separate request. @dustinfarris Can you try this version with your application to see if it's working with embedded records?

[benkonrath]

The embedded records are in records that are async loaded so that might be causing the problem. The ids that are being retrieved when I change to async: true are correct so ED resolves the embedded id but not the full record.

[benkonrath]

User error! It's working ... I didn't update ember-data to 1.13.6 properly. :) It's ready for review.

[holandes22]

Awesome! I'll give it a try today

[dustinfarris]

Works beautifully on my end. Stellar work, as always!

@holandes22 please merge when ready.

[holandes22]

Works perfectly for me too. Amazing work, thank you!
Merging now

[jpadilla]

Great stuff. Working for me too.

[Marthyn]

Awesomeness! Thanks!