Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plonkup - Document proof widgets evaluation constants #581

Closed
vlopes11 opened this issue Sep 23, 2021 · 1 comment · Fixed by #652
Closed

Plonkup - Document proof widgets evaluation constants #581

vlopes11 opened this issue Sep 23, 2021 · 1 comment · Fixed by #652
Labels
area:documentation Anything to improve our doc base module:plonkup Issue related to plonkup implementation team:Core Low Level Core Development Team (Rust)

Comments

@vlopes11
Copy link
Contributor

In modularise_plookup, a function ProverKey::num_multiset was introduced with constant value 4

However, this is not documented anywhere and could create some future confusion.

vlopes11 added a commit that referenced this issue Sep 23, 2021
Co-authored-by: Eduardo Leegwater Simões <eduardols@protonmail.com>

Related issue: #581
vlopes11 added a commit that referenced this issue Sep 23, 2021
Related issue: #581

Co-authored-by: Eduardo Leegwater Simões <eduardols@protonmail.com>
@vlopes11 vlopes11 added module:plonkup Issue related to plonkup implementation team:Core Low Level Core Development Team (Rust) labels Sep 27, 2021
@vlopes11 vlopes11 changed the title Document proof widgets evaluation constants Plonkup - Document proof widgets evaluation constants Sep 27, 2021
@ZER0 ZER0 added the area:documentation Anything to improve our doc base label Oct 6, 2021
@ZER0 ZER0 added this to the mile milestone Oct 6, 2021
@autholykos autholykos removed this from the mile milestone Oct 8, 2021
vlopes11 added a commit that referenced this issue Oct 18, 2021
Related issue: #581

Co-authored-by: Eduardo Leegwater Simões <eduardols@protonmail.com>
@moCello
Copy link
Member

moCello commented Nov 22, 2021

File: src/proof_system/widget.rs

 273   │         /// Returns the number of [`MultiSet`]s contained in a ProverKey.
 274   │         const fn num_multiset() -> usize {
 275   │             // FIXME https://github.com/dusk-network/plonk/issues/581
 276   │             4
 277   │         }

moCello added a commit that referenced this issue Dec 14, 2021
We need the size fo the ProverKey for serialization purposes.
All 'magic numbers' from the previous approach are eliminated.

Resolves: #581
@moCello moCello linked a pull request Dec 14, 2021 that will close this issue
moCello added a commit that referenced this issue Mar 4, 2022
We need the size fo the ProverKey for serialization purposes.
All 'magic numbers' from the previous approach are eliminated.

Resolves: #581
@moCello moCello closed this as completed in 3125d13 Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Anything to improve our doc base module:plonkup Issue related to plonkup implementation team:Core Low Level Core Development Team (Rust)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants