Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction provider #467

Merged
merged 9 commits into from
May 6, 2020
Merged

Transaction provider #467

merged 9 commits into from
May 6, 2020

Conversation

autholykos
Copy link
Member

This PR introduces the following interfaces:

  • Verifier: abstracts away the GRPC calls related to transaction verification
  • Provider: abstracts away the GRPC calls related to Transaction creation
  • Executor: abstracts away the GRPC calls related to Transaction execution
  • Provisioner: abstracts away the GRPC calls related to Provisioner operations
  • BlockGenerator: abstracts away the GRPC calls related to Block Generator operations
  • Consensus: abstracts away the GRPC calls related to BidList and Committee calculation

This layer of indirection allows surgical injection of just the right operations into the various node components, which presents also the added benefit of ease of testing and separation of concerns.

The PR includes all needed serializations to and from rusk protobuf structures as well as new transaction objects

@autholykos autholykos requested review from jules and devtomnl May 5, 2020 20:27
jules
jules suggested changes May 6, 2020
View reviewed changes
pkg/core/chain/chain.go Outdated Show resolved Hide resolved
pkg/core/consensus/user/sortition.go Show resolved Hide resolved
@autholykos
revert the channel listener to a callback for chain.onAcceptedBlock t…
ff833a2 
…o avoid race conditions with the synchronizer
jules
jules approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@jules jules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@autholykos autholykos mentioned this pull request May 6, 2020
Closed
@autholykos autholykos merged commit 798d98f into thomas/feature-411-mock May 6, 2020
@autholykos autholykos deleted the transaction-provider branch May 6, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jules jules jules approved these changes

@devtomnl devtomnl devtomnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autholykos @jules @devtomnl