Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final PR for docs, data types, cleanup and testing #42

Merged
merged 3 commits into from
Sep 15, 2018
Merged

Final PR for docs, data types, cleanup and testing #42

merged 3 commits into from
Sep 15, 2018
+362 −197

Conversation

tobias-urdin
Copy link
Contributor

@tobias-urdin tobias-urdin commented Aug 11, 2018 •
edited
Loading

Here is the final PR that:

  • Fixes all documentation and makes sure it follows Puppet Strings [1]
  • Updates README.md to follow standardized format
  • Adds CHANGELOG.md
  • Adds Puppet data types
  • Cleanup formatting of code
  • Make sysctl::base private class
  • Updates metadata.json to reflect only non-EOL operating systems
  • Run spec testing for major supported operating systems

[1] https://puppet.com/docs/puppet/5.5/puppet_strings.html

Best regards
Tobias

@tobias-urdin
Update documentation
76e5551 
* Updates documentation to follow the
  Puppet String[1] standard.

* Changes README to follow standard format.

* Adds CHANGELOG.md
@tobias-urdin
Remove EOL OS and add run spec test for supported
43c7bfc 
Removes all the EOL operating systems from the
metadata.json file and updates the lists to be up-to-date.

Changes the spec tests to using rspec-puppet-facts and
checking all the spec tests for some of the major supported
operating systems.
@tobias-urdin
Implement data types, cleanup, fix docs, fix formatting
05c77ef 
* Implements Puppet data types
* Cleanup code structure and formatting
* Fix docs for types and providers according to Puppet Strings
@tobias-urdin
Copy link
Contributor Author

tobias-urdin commented Aug 11, 2018 •
edited
Loading

IMO there is only one last thing to actually test and that would be using the newly provided examples/init.pp manifest to run actual module integration testing in TravisCI for the supported operating systems and then use serverspec [1] testing to validate the files and sysctl values in the operating system actually changed.

[1] https://serverspec.org/

Oh and a note on this final PR is that Puppet 3 is now no longer supported and users must use v0.0.12 which we released earlier.

Best regards
Tobias

@tobias-urdin
Copy link
Contributor Author

ping @duritong

@duritong
Copy link
Owner

Thanks, I am maintaining this module in my spare time and you need to give me some time (days) that I can look at such big patches. The last one (#39) I merged without careful review promptly broke lots of CI pipelines (#40).

@tobias-urdin
Copy link
Contributor Author

@duritong any update on this?

@tobias-urdin
Copy link
Contributor Author

ping

@duritong duritong merged commit 5d29778 into duritong:master Sep 15, 2018
@duritong
Copy link
Owner

Thank you very much. I am really sorry it took me so long to review and merge.

I would be very open to widen maintenance this module. I guess it would be good idea to migrate it to voxpupuli (https://voxpupuli.org/docs/#migrating-a-module-to-voxpupuli) and I would assume you already brought it into a good shape for that.

@tobias-urdin
Copy link
Contributor Author

Thanks @duritong :)
I noticed that I did a minor error on the code formatting in the README, here is a quick fix #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobias-urdin @duritong