Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates for Spring 5 support #180

Merged
merged 9 commits into from
Oct 23, 2023

Conversation

mikejritter
Copy link
Contributor

JIRA Ticket: ?

What does this Pull Request do?

Dependency Updates

  • Spring -> 5.3.27
  • Spring Security -> 5.8.3
  • Tiles -> 3.0.1
  • other minor bumps

Config Changes

  • Removed version from bean schema location where possible
  • Moved non-duracloud beans to java config
    • This was to help with updating packages, default parameters, etc, as I wasn't getting hints in the xml.

Spring Security

  • Use SecurityContextHolderStrategy when retrieving SecurityContext
  • Removed setting of SecurityContextHolder strategy
    • This is something which broke method security in the management-console, so I replicated the changes here as well though I'm not as certain if they're necessary. In addition, the SecurityContextHolderStrategy is retrieved first so this should be ok.
  • Configure an additional NoOpPasswordEncoder for durastore
    • @dbernstein this is what I had mentioned on our call the other week. This allows the http calls being made from duradmin to complete successfully but is something we'll want to take another look at. If you want I can get some more info, I forget exactly what class I was stepping through but I know it was hitting /stores.
  • Minor updates to move to MessageDigestPasswordEncoder

Tiles

  • API changes for updates to Tiles 3
  • Moved views.xml config to be in default location for the ViewResolver
  • Removed old AbstractSpringPreparerFactory
    • @dbernstein this is the other thing I had mentioned last week. As far as I can tell it wasn't being used in any way, and the application still deploys and is able to be used from my brief testing.

Other

  • Removed logging from BitIntegrityReportRest constructor
    • Since the object being logged is a request scoped proxy, this was throwing an exception in the Tomcat logs on startup. In favor of reducing noise I opted to remove this but could always add it back without the proxy object.
  • Various minor API updates, e.g. PageRequest.of

How should this be tested?

  • Verify the project still builds
  • Deploy into Tomcat and startup (with no errors)
  • Run integration tests please and thank you

Additional Notes:

I haven't run the integration tests yet, I've been meaning to try but need to verify my environment is setup correctly first.

Interested parties

@dbernstein

* Spring to v5
* commons-lang to 3.12
* Simple data/mvc/security updates
* Remove version from schema where possible
This is for both aop and mvc beans. Just to help with future
migrations where classes might get moved or other changes to
the config.
* Remove version from schema location
* Migrate password encoder
* Include a noop password encoder
* Use context holder strategy when getting security context
* Remove setting of strategy name for security context
The storageProviderFactory is request scoped and this was throwing an exception because there is no request context on init
@mikejritter mikejritter force-pushed the dependency-updates branch from 2c0a4c4 to acbe678 Compare May 5, 2023 19:24
Copy link
Member

@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thorough testing with the latest duracloud db will tell us a lot.

@dbernstein dbernstein merged commit 25f45e8 into duracloud:develop Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants