DURACLOUD-1279: Adds snapshot totals information to the UI, companion PR to DURACLOUD-1150 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernstein
reviewed
Nov 10, 2021
| public GetSnapshotsTotalsTaskResult getSnapshotsTotals(String status) | ||
| throws ContentStoreException { | ||
| if (null == status) { | ||
| status = "SNAPSHOT_COMPLETE"; |
There was a problem hiding this comment.
define a constant for SNAPSHOT_COMPLETE if it is not already defined elsewhere?
There was a problem hiding this comment.
Maybe add it to SnapshotConstants?
|
One note: you need to specify the host on the above SQL queries if you have more than one host in your snapshot table. |
dbernstein
approved these changes
Nov 10, 2021
|
This PR is good to go - one little suggestion but not required to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work of DURACLOUD-1150 to present information about snapshots (total count, size and files) in the UI.
JIRA Ticket: https://duracloud.atlassian.net/browse/DURACLOUD-1279
What does this Pull Request do?
This PR adds a snapshot totals pane to the GUI for snapshot storage providers when no spaces are selected. It uses the API calls added in DURACLOUD-1150 to get the statistics.
How should this be tested?
SELECT COUNT(id) FROM snapshot WHERE host = '$HOST' AND status = 'SNAPSHOT_COMPLETE';SELECT SUM(total_size_in_bytes) FROM snapshot WHERE host = '$HOST' AND status = 'SNAPSHOT_COMPLETE';SELECT COUNT(sci.id) FROM snapshot s LEFT JOIN snapshot_content_item sci ON s.id = sci.snapshot_id WHERE s.host = '$HOST' AND s.status = 'SNAPSHOT_COMPLETE';Interested parties
Tag @duracloud/committers