Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyOpenSSL dependency #27

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

gcoxmoz
Copy link
Contributor

@gcoxmoz gcoxmoz commented Sep 4, 2024

Description

The pyOpenSSL module in duo_universal_python does not appear to be referenced.

Motivation and Context

This change seeks to remove an unused module to reduce dependencies / attack surface.

How Has This Been Tested?

Skimmed the code looking for why it's needed, found nothing.
Ran the test suite, it continued to pass.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • None of the above?

requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@jeffreyparker jeffreyparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeffreyparker jeffreyparker merged commit 98d1a0a into duosecurity:main Dec 3, 2024
5 checks passed
@gcoxmoz gcoxmoz deleted the pyopenssl-removal branch December 3, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants