This repository has been archived by the owner on May 19, 2021. It is now read-only.
Fix addon 🙌🏻 #60
Merged
Fix addon 🙌🏻 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update
update-dependenciesbranch went through different cycles of trying to fix the addon caused by glimmerjs/glimmer-vm#453. The issue was eventually fixed by a patch release (glimmerjs/glimmer-vm#529) in ember v2.13.3 💪🏻Eventually, in upgrading the addon I also changed baseURL to rootURL, deprecated way back in Ember 2.7. This caused another issue (#57) but was fixed in 0d9691d.
Then lastly, the addon was suffering random test failures, traced down to issue #59, describing that PhantomJS caused this. However, simply including all polyfills instead of just the lite (fb52b07
) seems to have fixed the problem. Hurray 👐🏻
Time for a v1.0! 😻