fix: only drain workers on graceful shutdown. #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Feb 24, 2025
| func drainWorkers() { | ||
| watcher.DrainWatcher() | ||
| // DrainWorkers finishes all worker scripts before a graceful shutdown | ||
| func DrainWorkers() { |
There was a problem hiding this comment.
Is it necessary to make this function exported?
There was a problem hiding this comment.
The alternative would be to pass the 'soft shutdown' as a shutdown option if you prefer that.
frankenphp.Shutdown(frankenphp.WithSoftShutdown())
or something like that.
There was a problem hiding this comment.
Hum not really, we'll also need a new symbol :D
Maybe could we make this function experimental at least?
There was a problem hiding this comment.
Hmm i guess you're right that would just be even more complicated 😅 . I'll mark the endpoint as 'experimental'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1296
This PR changes the graceful shutdown to just drain all running worker scripts. It's faster and easier to just let the OS clean up all the remaining memory.