Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCRVUSD token on the Ethereum blockchain to prices.usd #7633

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

ytSOFA
Copy link
Contributor

@ytSOFA ytSOFA commented Feb 8, 2025

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[Add SCRVUSD token on the Ethereum blockchain to prices.usd.]


quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: tokens covers the Tokens dbt subproject labels Feb 8, 2025
@ytSOFA ytSOFA marked this pull request as ready for review February 8, 2025 07:01
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 8, 2025
@ytSOFA
Copy link
Contributor Author

ytSOFA commented Feb 8, 2025

Hi @Hosuke @jeff-dude, could you review it? Thanks.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @ytSOFA

@@ -1875,7 +1875,8 @@ FROM
('wagmi5-wagmi', 'ethereum', 'WAGMI', 0x92CC36D66e9d739D50673d1f27929a371FB83a67, 18),
('deusd-elixir-deusd','ethereum', 'DEUSD', 0x15700b564ca08d9439c58ca5053166e8317aa138, 18),
('unibot-unibot','ethereum', 'UNIBOT', 0xf819d9cb1c2a819fd991781a822de3ca8607c3c9, 18),
('morpho-morpho','ethereum', 'MORPHO', 0x58d97b57bb95320f9a05dc918aef65434969c2b2, 18)
('morpho-morpho','ethereum', 'MORPHO', 0x58d97b57bb95320f9a05dc918aef65434969c2b2, 18),
('scrvusd-savings-crvusd', 'ethereum', 'SCRVUSD', 0x0655977FEb2f289A4aB78af67BAB0d17aAb84367, 18)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hosuke Hosuke added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Feb 8, 2025
@aalan3 aalan3 merged commit d97011e into duneanalytics:main Feb 10, 2025
6 checks passed
Copy link

gitpoap-bot bot commented Feb 10, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Dune Contributor:

GitPOAP: 2025 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: tokens covers the Tokens dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants