creating EVM net transfers #7512
Open
+1,699
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-dude
requested changes
Jan 21, 2025
dbt_subprojects/tokens/models/transfers_and_balances/arbitrum/_schema.yml
Outdated
Show resolved
Hide resolved
…_schema.yml Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
…espective schema, updated tokens_net_transfers_daily_address.sql and tokens_net_transfers_daily.sql to include all chains I made changes for
…_transfers_arbitrum
jeff-dude
requested changes
Feb 5, 2025
...s/models/transfers_and_balances/arbitrum/tokens_arbitrum_net_value_transfers_asset_daily.sql
Outdated
Show resolved
Hide resolved
...s/models/transfers_and_balances/arbitrum/tokens_arbitrum_net_value_transfers_asset_daily.sql
Outdated
Show resolved
Hide resolved
|
|
||
| {% ############################################################################################ %} | ||
|
|
||
| {% macro evm_net_value_transfers_asset_daily(blockchain) %} |
There was a problem hiding this comment.
Suggested change
| {% macro evm_net_value_transfers_asset_daily(blockchain) %} | |
| {% macro evm_net_transfers_daily_asset(blockchain) %} |
There was a problem hiding this comment.
i wonder if we keep this naming standard, then use net_value_transferred_amount_usd as the final column name? that way we use the naming standard introduced in PRD for actual column values, then maintain consistency with other macro / tables at table level
There was a problem hiding this comment.
do you mean instead of filtered_net_transfer_amount_usd from the macro we use net_value_transferred_amount_usd as the name yeah?
dbt_subprojects/tokens/models/transfers_and_balances/_schema.yml
Outdated
Show resolved
Hide resolved
dbt_subprojects/tokens/models/transfers_and_balances/arbitrum/_schema.yml
Outdated
Show resolved
Hide resolved
dbt_subprojects/tokens/models/transfers_and_balances/arbitrum/_schema.yml
Outdated
Show resolved
Hide resolved
| , address | ||
| , sum(coalesce(transfer_amount_usd_sent, 0)) as transfer_amount_usd_sent | ||
| , sum(coalesce(transfer_amount_usd_received, 0)) as transfer_amount_usd_received | ||
| , sum(coalesce(transfer_amount_usd_received, 0)) + sum(coalesce(transfer_amount_usd_sent, 0)) as net_transfer_amount_usd |
There was a problem hiding this comment.
Suggested change
| , sum(coalesce(transfer_amount_usd_received, 0)) + sum(coalesce(transfer_amount_usd_sent, 0)) as net_transfer_amount_usd | |
| , sum(coalesce(transfer_amount_usd_received, 0)) + sum(coalesce(transfer_amount_usd_sent, 0)) as net_value_transferred_amount_usd |
| , sum(transfer_amount_usd_sent) as transfer_amount_usd_sent | ||
| , sum(transfer_amount_usd_received) as transfer_amount_usd_received | ||
| -- , sum(abs(transfer_amount_usd_sent)) + sum(abs(transfer_amount_usd_received)) as transfer_amount_usd | ||
| , sum(net_transfer_amount_usd) as net_transfer_amount_usd |
There was a problem hiding this comment.
Suggested change
| , sum(net_transfer_amount_usd) as net_transfer_amount_usd | |
| , sum(net_value_transferred_amount_usd) as net_value_transferred_amount_usd |
| from | ||
| net_transfers | ||
| where | ||
| net_transfer_amount_usd > 0 |
There was a problem hiding this comment.
Suggested change
| net_transfer_amount_usd > 0 | |
| net_value_transferred_amount_usd > 0 |
There was a problem hiding this comment.
I think here the filter won't work because we changed the variable from , sum(net_transfer_amount_usd) as net_value_transferred_amount_usd in the select statement so the where filter would not understand net_value_transferred_amount_usd > 0, Could we instead try this after the group by clause?
HAVING
sum(net_transfer_amount_usd) > 0
…er in schema for each chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
Updated 7 files for net transfers
quick links for more information: