Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morpho on Base #7498

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Morpho on Base #7498

merged 11 commits into from
Jan 21, 2025

Conversation

0xdatawolf001
Copy link
Contributor

This is a PR to add Morpho (Base) to the lending sector tables based on the requests from SeaLaunch

#7235

@github-actions github-actions bot marked this pull request as draft January 20, 2025 08:24
@github-actions github-actions bot added WIP work in progress dbt: hourly covers the hourly dbt subproject labels Jan 20, 2025
@0xdatawolf001
Copy link
Contributor Author

Not super sure how to fix this error? I can find the tables on Dune (front end). Is there some dependencies in some sql or yml file that I have not configured?

@jeff-dude
Copy link
Member

Not super sure how to fix this error? I can find the tables on Dune (front end). Is there some dependencies in some sql or yml file that I have not configured?

any time you use jinja to call a source in dbt, you need to declare in the defined sources directory. for your use case, that would be somewhere here:
https://github.com/duneanalytics/spellbook/tree/main/sources/_sector/lending

@0xdatawolf001
Copy link
Contributor Author

corrected the relevant bits

@0xdatawolf001 0xdatawolf001 marked this pull request as ready for review January 21, 2025 07:34
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 21, 2025
@jeff-dude jeff-dude self-assigned this Jan 21, 2025
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean add here, thank you 🔥

fyi, we have this lending sector spell in our backlog to revisit and enhance when we get the time. it could be a good table to build out with extensive coverage and validate the table schema and such.

@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jan 21, 2025
@jeff-dude jeff-dude merged commit 383642f into duneanalytics:main Jan 21, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
@0xdatawolf001 0xdatawolf001 deleted the morphoOnBase branch January 22, 2025 01:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: hourly covers the hourly dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants