Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pcsx on arb to dex trades #7465

Merged

Conversation

ChefButterBeer
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

Add pancakeswapx on arbitrum to dex trades

quick links for more information:

@ChefButterBeer
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions github-actions bot marked this pull request as draft January 15, 2025 05:09
@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jan 15, 2025
@Hosuke
Copy link
Collaborator

Hosuke commented Jan 18, 2025

If this PR is ready, you can mark this PR ready for review.

@ChefButterBeer ChefButterBeer marked this pull request as ready for review January 20, 2025 03:11
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 20, 2025
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @ChefButterBeer

@Hosuke Hosuke added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jan 20, 2025
@jeff-dude jeff-dude merged commit c4c4123 into duneanalytics:main Jan 20, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants