Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avantis Protocol on Base #7450

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

PatelPrinci
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot marked this pull request as draft January 10, 2025 10:22
@github-actions github-actions bot added WIP work in progress dbt: hourly covers the hourly dbt subproject labels Jan 10, 2025
@PatelPrinci PatelPrinci marked this pull request as ready for review January 10, 2025 10:30
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 10, 2025
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jan 13, 2025
@PatelPrinci
Copy link
Contributor Author

PatelPrinci commented Jan 17, 2025 via email

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @PatelPrinci

Sample avantis_v1_base_perpetual_trades

Please allow maintainers' edit in future PRs.

@Hosuke Hosuke added ready-for-final-review and removed in review Assignee is currently reviewing the PR labels Jan 22, 2025
@Hosuke Hosuke assigned jeff-dude and unassigned Hosuke Jan 22, 2025
@jeff-dude jeff-dude added WIP work in progress and removed ready-for-final-review labels Jan 29, 2025
@@ -0,0 +1,220 @@
{{ config(
schema = 'avantis_base',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schema = 'avantis_base',
schema = 'avantis_v1_base',

@@ -0,0 +1,46 @@
{{ config(
schema = 'avantis_perpetual_trades',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schema = 'avantis_perpetual_trades',
schema = 'avantis_base',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: hourly covers the hourly dbt subproject WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants