Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safe Optimism Balances #6498

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Conversation

safeintern
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@dune-eng
Copy link

dune-eng commented Aug 5, 2024

Workflow run id 10244665912 approved.

@dune-eng
Copy link

dune-eng commented Aug 5, 2024

Workflow run id 10244665706 approved.

@dune-eng
Copy link

dune-eng commented Aug 5, 2024

Workflow run id 10244697564 approved.

@dune-eng
Copy link

dune-eng commented Aug 5, 2024

Workflow run id 10244697211 approved.

@dune-eng
Copy link

dune-eng commented Aug 5, 2024

Workflow run id 10246075767 approved.

@dune-eng
Copy link

dune-eng commented Aug 5, 2024

Workflow run id 10246075967 approved.

Added sources for Safe's balances on Polygon and Optimism
@dune-eng
Copy link

dune-eng commented Aug 5, 2024

Workflow run id 10246311927 approved.

@dune-eng
Copy link

dune-eng commented Aug 5, 2024

Workflow run id 10246312338 approved.

@safeintern
Copy link
Contributor Author

@jeff-dude can you please take a look at this? Thank you!

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10289218100 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10289217944 approved.

@jeff-dude jeff-dude self-assigned this Aug 7, 2024
@jeff-dude jeff-dude added the ready-for-review this PR development is complete, please review label Aug 7, 2024
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Aug 9, 2024
@jeff-dude jeff-dude merged commit 12f01f8 into duneanalytics:main Aug 9, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants