-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FOR REVIEW] Add zeroex settler txns on ethereum #6405
Conversation
Update socialtokens.sql
Workflow run id 10084346816 approved. |
Workflow run id 10084346818 approved. |
Workflow run id 10102091561 approved. |
Workflow run id 10102091723 approved. |
Workflow run id 10102091722 approved. |
this is updated to match #6425 |
trades.block_number, | ||
zid, | ||
trades.contract_address, | ||
methodID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the naming standard in #6425 mentioned.
alias = 'settler_trades', | ||
materialized='incremental', | ||
partition_by = ['block_month'], | ||
unique_key = ['block_date', 'tx_hash', 'evt_index'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unique_key = ['block_date', 'tx_hash', 'evt_index'], | |
unique_key = ['block_month', 'block_date', 'tx_hash', 'evt_index'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing out. this polygon model wasn't intended to be included here. it's now removed @Hosuke
Workflow run id 10147869497 approved. |
Workflow run id 10147869775 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅
Thank you @RantumBits
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information: