Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOR REVIEW] Add zeroex settler txns on ethereum #6405

Merged
merged 132 commits into from
Jul 30, 2024

Conversation

RantumBits
Copy link
Contributor

@RantumBits RantumBits commented Jul 22, 2024

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name zeroex_ethereum.settler_trades
  • Description: [Detailed description of the new spell(s) and their purpose] decode 0x API trades on new settler contracts
  • Who are the new spell(s) for? [Internal team or general community] Both
  • How will the new spell(s) be used downstream? [Description of downstream usage] Merged into dex_aggregator.trades
  • Implementation details: [Information on how the spell(s) are implemented] gets taker and maker amounts only, no fills level data for intermediary swaps
  • Test instructions: [How to test the new spell(s)]- https://dune.com/queries/3921632
  • Related issue(s): [Link to related issues, if any]

RantumBits and others added 30 commits June 1, 2021 14:07
@dune-eng
Copy link

Workflow run id 10084346816 approved.

@dune-eng
Copy link

Workflow run id 10084346818 approved.

@dune-eng
Copy link

Workflow run id 10102091561 approved.

@dune-eng
Copy link

Workflow run id 10102091723 approved.

@dune-eng
Copy link

Workflow run id 10102091722 approved.

@RantumBits
Copy link
Contributor Author

this is updated to match #6425

trades.block_number,
zid,
trades.contract_address,
methodID,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the naming standard in #6425 mentioned.

alias = 'settler_trades',
materialized='incremental',
partition_by = ['block_month'],
unique_key = ['block_date', 'tx_hash', 'evt_index'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unique_key = ['block_date', 'tx_hash', 'evt_index'],
unique_key = ['block_month', 'block_date', 'tx_hash', 'evt_index'],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing out. this polygon model wasn't intended to be included here. it's now removed @Hosuke

@dune-eng
Copy link

Workflow run id 10147869497 approved.

@dune-eng
Copy link

Workflow run id 10147869775 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hosuke Hosuke added ready-for-final-review and removed ready-for-review this PR development is complete, please review labels Jul 29, 2024
@Hosuke Hosuke assigned jeff-dude and unassigned Hosuke Jul 29, 2024
@jeff-dude jeff-dude merged commit 48f3924 into duneanalytics:main Jul 30, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants