Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASY] Fix missing USD pricing on certain zkSync nft.trades #5712

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

lgingerich
Copy link
Contributor

Should be an easy one, just needed to fix some matching on contracts for pricing

  • Replace 0x000 contract with proper ETH contract
  • Replace non-primary WETH contract with the proper WETH contract

@dune-eng
Copy link

dune-eng commented Apr 2, 2024

Workflow run id 8515432970 approved.

@dune-eng
Copy link

dune-eng commented Apr 2, 2024

Workflow run id 8515433117 approved.

@dune-eng
Copy link

dune-eng commented Apr 2, 2024

Workflow run id 8515555412 approved.

@dune-eng
Copy link

dune-eng commented Apr 2, 2024

Workflow run id 8515555629 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @lgingerich

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @0xRobin

@jeff-dude jeff-dude self-assigned this Apr 4, 2024
@jeff-dude jeff-dude added the dbt: nft covers the NFT dbt subproject label Apr 4, 2024
@jeff-dude jeff-dude merged commit 45509e5 into duneanalytics:main Apr 5, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
@lgingerich lgingerich deleted the fix_zksync_nft_pricing branch July 26, 2024 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: nft covers the NFT dbt subproject easy ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants