Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clipper to dex.trades_beta #5043

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Add clipper to dex.trades_beta #5043

merged 7 commits into from
Jan 3, 2024

Conversation

tomfutago
Copy link
Contributor

@tomfutago tomfutago commented Dec 22, 2023 •
edited
Loading

linked to #4759

@dune-eng
Copy link

Workflow run id 7301363929 approved.

@dune-eng
Copy link

Workflow run id 7301364035 approved.

@dune-eng
Copy link

Workflow run id 7301646881 approved.

@dune-eng
Copy link

Workflow run id 7301646983 approved.

@tomfutago tomfutago marked this pull request as ready for review December 22, 2023 16:04
@jeff-dude jeff-dude requested a review from Hosuke December 22, 2023 18:11
@jeff-dude jeff-dude added ready-for-merging dbt: dex covers the DEX dbt subproject ready-for-review this PR development is complete, please review and removed ready-for-merging labels Dec 22, 2023
Hosuke
Hosuke approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @tomfutago

Sample clipper_arbitrum_base_trades
Sample clipper_ethereum_base_trades
Sample clipper_optimism_base_trades
Sample clipper_polygon_base_trades

@Hosuke Hosuke added ready-for-final-review and removed ready-for-review this PR development is complete, please review labels Dec 26, 2023
@Hosuke Hosuke assigned jeff-dude and unassigned Hosuke Jan 2, 2024
@jeff-dude jeff-dude added WIP work in progress and removed ready-for-final-review labels Jan 2, 2024
@dune-eng
Copy link

dune-eng commented Jan 3, 2024

Workflow run id 7396474910 approved.

@dune-eng
Copy link

dune-eng commented Jan 3, 2024

Workflow run id 7396475217 approved.

@dune-eng
Copy link

dune-eng commented Jan 3, 2024

Workflow run id 7396617001 approved.

@dune-eng
Copy link

dune-eng commented Jan 3, 2024

Workflow run id 7396617214 approved.

@jeff-dude jeff-dude removed the WIP work in progress label Jan 3, 2024
@jeff-dude jeff-dude merged commit c4a200e into duneanalytics:main Jan 3, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude requested changes

@Hosuke Hosuke Hosuke approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomfutago @dune-eng @Hosuke @jeff-dude