Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verse_dex to dex.trades_beta #5011

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Add verse_dex to dex.trades_beta #5011

merged 2 commits into from
Dec 19, 2023

Conversation

tomfutago
Copy link
Contributor

@tomfutago tomfutago commented Dec 17, 2023 •
edited
Loading

linked to #4759

@dune-eng
Copy link

Workflow run id 7239241258 approved.

@dune-eng
Copy link

Workflow run id 7239241318 approved.

@tomfutago tomfutago marked this pull request as ready for review December 17, 2023 15:04
@jeff-dude jeff-dude requested a review from Hosuke December 18, 2023 16:36
@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review dbt: dex covers the DEX dbt subproject labels Dec 18, 2023
Hosuke
Hosuke approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @tomfutago

Sample verse_dex_ethereum_base_trades

@Hosuke Hosuke added ready-for-final-review and removed ready-for-review this PR development is complete, please review labels Dec 19, 2023
@Hosuke Hosuke assigned jeff-dude and unassigned Hosuke Dec 19, 2023
@jeff-dude jeff-dude merged commit 6c26ea1 into duneanalytics:main Dec 19, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hosuke Hosuke Hosuke approved these changes

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: dex covers the DEX dbt subproject
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomfutago @dune-eng @Hosuke @jeff-dude