Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mummy_finance optimism trades #4861

Merged
merged 83 commits into from
Nov 30, 2023
Merged

Added mummy_finance optimism trades #4861

merged 83 commits into from
Nov 30, 2023

Conversation

ARDev097
Copy link
Contributor

Added trades data for mummy_finance optimism dex

ARDev097 and others added 30 commits October 7, 2023 12:26
@ARDev097
add openxswap trades
769ddc8
@ARDev097
Merge branch 'main' into main
94fa2d1
@ARDev097
add legacy file for openxswap trades
6016d6b
@ARDev097
Merge branch 'main' of https://github.com/ARDev097/spellbook
5ac28b1
@ARDev097
update legacy file for openxswap trades
7930509
@ARDev097
Add seeds records for openxswap
1117163
@Hosuke
Add uniqueness and check_dex_seed tests
cee2755
@ARDev097
updated seeds records for openxswap
ede1f32
@ARDev097
Merge branch 'main' of https://github.com/ARDev097/spellbook
52d4018
@Hosuke
Merge branch 'main' into main
f45d1a4
@ARDev097
added openocean dex
a672611
@ARDev097
Added seed data for openocean dex
b055157
@ARDev097
Added seed data for openocean dex
69db76e
@ARDev097
Merge branch 'main' into main
f8a31db
@ARDev097
Updated dex_trades_assert_freshness file
b111fc7
@ARDev097
Merge branch 'main' of https://github.com/ARDev097/spellbook
31f685e
@ARDev097
Updated trades.sql file
ef1ddde
@ARDev097
Updated trades.sql file
b566e57
@ARDev097
Merge branch 'main' into main
40319ca
@ARDev097
Modified schema file
4c16a37
@ARDev097
Merge branch 'main' of https://github.com/ARDev097/spellbook
398df12
@ARDev097
Merge branch 'main' into main
e83ba26
@ARDev097
Modified schema file
8b00d70
@ARDev097
Merge branch 'main' of https://github.com/ARDev097/spellbook
d038792
@ARDev097
Modified schema file
252ca47
@ARDev097
Modified schema file
b392a25
@ARDev097
Modified schema file
17305c2
@ARDev097
Modified schema file
c65b9ab
@ARDev097
Modified seeds file
30d2ffe
@ARDev097
Merge branch 'main' into main
6fcab01
@dune-eng
Copy link

Workflow run id 6979619090 approved.

@dune-eng
Copy link

Workflow run id 6979619031 approved.

@dune-eng
Copy link

Workflow run id 6983243284 approved.

@dune-eng
Copy link

Workflow run id 6983243368 approved.

@ARDev097
Copy link
Contributor Author

Hello @Hosuke ,
I've encountered an error in the 'dex_trades_assert_freshness.sql' file after implementing the macro approach in the Mummy Finance DEX. I've reviewed my changes, but I'm unable to pinpoint the issue. Could you please take a look and provide guidance on how to correct it?

image

@dune-eng
Copy link

Workflow run id 7000498676 approved.

@dune-eng
Copy link

Workflow run id 7000498654 approved.

@dune-eng
Copy link

Workflow run id 7000597823 approved.

@dune-eng
Copy link

Workflow run id 7000597898 approved.

@Hosuke
Copy link
Collaborator

Hosuke commented Nov 27, 2023

The data freshness issue is unrelated to this PR.

Hosuke
Hosuke approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @ARDev097

Sample mummy_finance_optimism_base_trades
Sample mummy_finance_optimism_trades

tests/dex/dex_trades_assert_freshness.sql Outdated Show resolved Hide resolved
@dune-eng
Copy link

Workflow run id 7041502916 approved.

@dune-eng
Copy link

Workflow run id 7041503100 approved.

@ARDev097
Copy link
Contributor Author

Hello @Hosuke ,
This PR still hasn't been merged. Please review it, and inform me if there is anything that needs to be done on my end.

@Hosuke Hosuke assigned jeff-dude and unassigned Hosuke Nov 30, 2023
@Hosuke
Copy link
Collaborator

Hosuke commented Nov 30, 2023

Hello @Hosuke , This PR still hasn't been merged. Please review it, and inform me if there is anything that needs to be done on my end.

Just noticed all tests passed now, I will pass this PR to final review.

jeff-dude
jeff-dude approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the patience 🙏

@jeff-dude jeff-dude merged commit 6f1f8e4 into duneanalytics:main Nov 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hosuke Hosuke Hosuke approved these changes

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: dex covers the DEX dbt subproject
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ARDev097 @dune-eng @Hosuke @jeff-dude