Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPE-224: expand existing add_tx_from_and_to and make generic #4757

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

jeff-dude
Copy link
Member

rather than focus on two columns, expand the macro to pull various columns from <blockchain>.transactions

@jeff-dude jeff-dude added enhancement New feature or request WIP work in progress dune team created by dune team labels Nov 9, 2023
@jeff-dude
Copy link
Member Author

fyi @grkhr if you want to give a review for your usage as well

Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very neat. 👍

@grkhr
Copy link
Contributor

grkhr commented Nov 9, 2023

thanks! LGTM

@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress labels Nov 9, 2023
model_cte
,blockchain
, blockchain
, columns = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jeff-dude jeff-dude merged commit 318fb40 into main Nov 10, 2023
@jeff-dude jeff-dude deleted the update-tx-macro branch November 10, 2023 13:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dune team created by dune team enhancement New feature or request ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants