Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init: Referrals sector #4519

Merged
merged 37 commits into from
Oct 20, 2023
Merged

Init: Referrals sector #4519

merged 37 commits into from
Oct 20, 2023

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Oct 4, 2023

Initial setup of a sector spell to track and analyze referral rewards payed out by protocols.
Currently contains data for:

  • zora
  • rabbithole
  • sound_xyz

@0xRobin 0xRobin marked this pull request as ready for review October 5, 2023 07:44
@0xRobin 0xRobin added the ready-for-review this PR development is complete, please review label Oct 5, 2023
@0xRobin 0xRobin requested a review from jeff-dude October 5, 2023 07:45
@jeff-dude jeff-dude self-assigned this Oct 5, 2023
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Oct 9, 2023
@0xRobin
Copy link
Collaborator Author

0xRobin commented Oct 18, 2023

@aalan3 @jeff-dude, I adapted this new sector according to our discussion.
I tried having the top level as a view, but that resulted in really long query times so I reverted back to materializing it.

I hope we can push this through so this new sector data is available in Dune and we can iterate on the different materialization strategies in follow up PR's. 🙏

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a few comments below for now 🙏

@jeff-dude
Copy link
Member

fyi @aalan3 @couralex6 @Hosuke
good example of working towards our clean sector-level spell designs moving forward

@0xRobin 0xRobin requested a review from jeff-dude October 20, 2023 09:28
@Hosuke
Copy link
Collaborator

Hosuke commented Oct 20, 2023

Impressive.

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment below, but let's proceed and clean up later if needed

a pleasure to review, as always -- thank you!

Comment on lines +30 to +35
inner join {{source(blockchain, 'transactions')}} tx
on evt_block_number = tx.block_number
and evt_tx_hash = tx.hash
{% if is_incremental() %}
and {{incremental_predicate('tx.block_time')}}
{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't let this block the PR, but i think this is missing the new macro step for joining to transactions, similar to others?

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Oct 20, 2023
@jeff-dude jeff-dude merged commit 3a35a6e into duneanalytics:main Oct 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
@0xRobin 0xRobin deleted the referrals-sector branch May 20, 2024 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants