Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate airdrop_optimism.addresses_1 #4444

Closed

Conversation

hildobby
Copy link
Collaborator

Thank you for contributing to Spellbook!

Please refer to the top of the readme in the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.

@hildobby hildobby added the ready-for-review this PR development is complete, please review label Sep 28, 2023
@Hosuke
Copy link
Collaborator

Hosuke commented Oct 4, 2023

Do you think the addresses now are covered in dune.oplabspbc.dataset_op_airdrop1_addresses_detailed_list?

@hildobby
Copy link
Collaborator Author

hildobby commented Oct 4, 2023

Do you think the addresses now are covered in dune.oplabspbc.dataset_op_airdrop1_addresses_detailed_list?

@MSilb7, all good on the airdrop list front? It might be worth having a spell that's a view of all the uploaded tables joined together? If you're down lmk the table names and I try to figure out how to tackle this. @jeff-dude, dune uploaded tables can be used in spellbook, right?

@jeff-dude
Copy link
Member

Do you think the addresses now are covered in dune.oplabspbc.dataset_op_airdrop1_addresses_detailed_list?

@MSilb7, all good on the airdrop list front? It might be worth having a spell that's a view of all the uploaded tables joined together? If you're down lmk the table names and I try to figure out how to tackle this. @jeff-dude, dune uploaded tables can be used in spellbook, right?

yeah, still finalizing the details on what is/isn't allowed (especially since free tier users can't use the upload feature on the app), but for now, we approved the approach for OP airdrops. the static spell in this PR is too large to include in spellbook, we are actively going away from that pattern if files get too large.

@jeff-dude jeff-dude added question Further information is requested and removed ready-for-review this PR development is complete, please review labels Oct 4, 2023
@jeff-dude
Copy link
Member

closing due to comment above, airdrop is now a dune upload and a source in spellbook

@jeff-dude jeff-dude closed this Oct 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants