SPE-118 Gas migration #4405
SPE-118 Gas migration #4405
Conversation
|
@hildobby @MSilb7 these tables are very heavy on the runs. And looking at our internal data the only one that's actually being queried right now is the optimism version. How useful are these tables for you at the moment? And are there any plans to build on top of them? Otherwise we are considering not migrating these and removing them except for on Optimism. EDIT: Disregard in this PR. I was referring to |
I was thinking of starting to use them soon. Do you think you could migrate them all but disable in prod all of them except optimism? That would make it much easier to re-add them when I want to start using them Also, this spell came as a follow-up to 3 separate requests from devs for queries on some txs with the same method. I for one want to use it but I'm sure many devs would love to use them (very useful to compare gas optimisation for example). But like most of dune, one of the biggest issues is discoverability and ppl not being aware of the spells that are out there |
|
Sorry I made a mistake 🤦♂️ these tables should be migrated without exception. These actually do have some usage. My comment above was meant for |
Ah, consider my answer for fees_traces then actually haha, that's what I was thinking of actually |
|
Ah nice 😄 ok then we can exclude the non optimism ones for now and enable them once you start building on top of them again. |
| txns.effective_gas_price/1e9 as gas_price_gwei, | ||
| txns.effective_gas_price/1e18 * p.price as gas_price_usd, | ||
| txns.gas_price/1e9 as gas_price_bid_gwei, | ||
| txns.gas_price/1e18 * p.price as gas_price_bid_usd, | ||
| txns.gas_used as gas_used, | ||
| txns.gas_limit as gas_limit, | ||
| txns.gas_used / txns.gas_limit * 100 as gas_usage_percent, | ||
| CASE | ||
| WHEN txns.gas_limit = 0 THEN NULL |
There was a problem hiding this comment.
Should we do 0 on these instead?
There was a problem hiding this comment.
They're null on the spark version right now so I wanted to keep that. We're dividing by 0, so it's not technically 0
|
Row counts match and the translation for |
Thank you for contributing to Spellbook!
Please refer to the top of the
readmein the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.