-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts: Split Spells in to 3 & update Creator Logic for smart wallet deployers #4319
Conversation
Workflow run id 6162664350 approved. |
Workflow run id 6162664522 approved. |
Workflow run id 6162719891 approved. |
Workflow run id 6162719971 approved. |
Workflow run id 6162860885 approved. |
Workflow run id 6162860970 approved. |
Workflow run id 6162983173 approved. |
Workflow run id 6162983245 approved. |
Workflow run id 6163056827 approved. |
Workflow run id 6163056726 approved. |
Workflow run id 6207341104 approved. |
Workflow run id 6207341062 approved. |
Workflow run id 6207428737 approved. |
Workflow run id 6207428768 approved. |
Workflow run id 6207503743 approved. |
Workflow run id 6207503759 approved. |
Workflow run id 6207538624 approved. |
Workflow run id 6207538700 approved. |
Workflow run id 6871023603 approved. |
Workflow run id 6871023725 approved. |
Maybe we close this and instead use this to #4747 - which also adds OP and removes the complexity of re-running old models. |
Workflow run id 6871404591 approved. |
Workflow run id 6871404718 approved. |
Workflow run id 6878670030 approved. |
Workflow run id 6878670256 approved. |
Workflow run id 6878902043 approved. |
Workflow run id 6878902144 approved. |
Workflow run id 6879633886 approved. |
Workflow run id 6879634281 approved. |
Workflow run id 6880664146 approved. |
Workflow run id 6880664311 approved. |
Workflow run id 6880705976 approved. |
Workflow run id 6880705965 approved. |
Workflow run id 6880721705 approved. |
Workflow run id 6880721833 approved. |
Workflow run id 6880756398 approved. |
Workflow run id 6880756629 approved. |
Closing in favor of #4747 |
Add method IDs for smart wallet transactions & add handling for deployers.
Also reduced the 'max_levels' to 3 (maybe 4) for now. Localized the iteration CTEs inside another CTE which I hope helps with runtime since we don't store as much memory globally in the query (if that's how it works).
create2
, since the deterministic deployer list is never going to be 100% sufficient.EDIT Oct 24:
Step 1: Generate the universe of contracts, with a flag for what needs to be iterated through (base level)
Step 2: iterate through contract creations to get the top-level creator
Step 3: Map contracts to the contract project, add predeploys, missing contracts, token symbol and standard.