Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts: Split Spells in to 3 & update Creator Logic for smart wallet deployers #4319

Closed
wants to merge 127 commits into from

Conversation

MSilb7
Copy link
Contributor

@MSilb7 MSilb7 commented Sep 12, 2023

Add method IDs for smart wallet transactions & add handling for deployers.

Also reduced the 'max_levels' to 3 (maybe 4) for now. Localized the iteration CTEs inside another CTE which I hope helps with runtime since we don't store as much memory globally in the query (if that's how it works).

  • Help with runtime
  • Longer-term, we should try to figure out how to more intelligently work up the "contract deployed by contract deployed by contract..."
  • Also - want to figure out how we can determine what's a create2, since the deterministic deployer list is never going to be 100% sufficient.

EDIT Oct 24:

  • This also now splits the spell in to 3 macros/spells to help with runtime
  • We don't touch contract creator list, tokens, and other static files until the very last spell, which just maps names and fields.

Step 1: Generate the universe of contracts, with a flag for what needs to be iterated through (base level)
Step 2: iterate through contract creations to get the top-level creator
Step 3: Map contracts to the contract project, add predeploys, missing contracts, token symbol and standard.

@dune-eng
Copy link

Workflow run id 6162664350 approved.

@dune-eng
Copy link

Workflow run id 6162664522 approved.

@dune-eng
Copy link

Workflow run id 6162719891 approved.

@dune-eng
Copy link

Workflow run id 6162719971 approved.

@dune-eng
Copy link

Workflow run id 6162860885 approved.

@dune-eng
Copy link

Workflow run id 6162860970 approved.

@dune-eng
Copy link

Workflow run id 6162983173 approved.

@dune-eng
Copy link

Workflow run id 6162983245 approved.

@dune-eng
Copy link

Workflow run id 6163056827 approved.

@dune-eng
Copy link

Workflow run id 6163056726 approved.

@dune-eng
Copy link

Workflow run id 6207341104 approved.

@dune-eng
Copy link

Workflow run id 6207341062 approved.

@dune-eng
Copy link

Workflow run id 6207428737 approved.

@dune-eng
Copy link

Workflow run id 6207428768 approved.

@dune-eng
Copy link

Workflow run id 6207503743 approved.

@dune-eng
Copy link

Workflow run id 6207503759 approved.

@dune-eng
Copy link

Workflow run id 6207538624 approved.

@dune-eng
Copy link

Workflow run id 6207538700 approved.

@dune-eng
Copy link

Workflow run id 6871023603 approved.

@dune-eng
Copy link

Workflow run id 6871023725 approved.

@MSilb7
Copy link
Contributor Author

MSilb7 commented Nov 15, 2023

Maybe we close this and instead use this to #4747 - which also adds OP and removes the complexity of re-running old models.

@dune-eng
Copy link

Workflow run id 6871404591 approved.

@dune-eng
Copy link

Workflow run id 6871404718 approved.

@dune-eng
Copy link

Workflow run id 6878670030 approved.

@dune-eng
Copy link

Workflow run id 6878670256 approved.

@dune-eng
Copy link

Workflow run id 6878902043 approved.

@dune-eng
Copy link

Workflow run id 6878902144 approved.

@dune-eng
Copy link

Workflow run id 6879633886 approved.

@dune-eng
Copy link

Workflow run id 6879634281 approved.

@dune-eng
Copy link

Workflow run id 6880664146 approved.

@dune-eng
Copy link

Workflow run id 6880664311 approved.

@dune-eng
Copy link

Workflow run id 6880705976 approved.

@dune-eng
Copy link

Workflow run id 6880705965 approved.

@dune-eng
Copy link

Workflow run id 6880721705 approved.

@dune-eng
Copy link

Workflow run id 6880721833 approved.

@dune-eng
Copy link

Workflow run id 6880756398 approved.

@dune-eng
Copy link

Workflow run id 6880756629 approved.

@MSilb7
Copy link
Contributor Author

MSilb7 commented Nov 15, 2023

Closing in favor of #4747

@MSilb7 MSilb7 closed this Nov 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in review Assignee is currently reviewing the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants