Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashloans Migration - #1 - Aave - Ready for review #4294

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

henrystats
Copy link
Contributor

Thank you for contributing to Spellbook!

Please refer to the top of the readme in the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.

@dune-eng
Copy link

dune-eng commented Sep 8, 2023

Workflow run id 6126619227 approved.

@dune-eng
Copy link

dune-eng commented Sep 8, 2023

Workflow run id 6126619147 approved.

@dune-eng
Copy link

dune-eng commented Sep 8, 2023

Workflow run id 6126759103 approved.

@dune-eng
Copy link

dune-eng commented Sep 8, 2023

Workflow run id 6126759244 approved.

@henrystats henrystats changed the title Flashloans Migration - #1 - Aave Flashloans Migration - #1 - Aave - Ready for review Sep 8, 2023
@Hosuke Hosuke added the ready-for-review this PR development is complete, please review label Sep 10, 2023
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @henrystats

Sample aave.flashloans

@Hosuke Hosuke added ready-for-final-review and removed ready-for-review this PR development is complete, please review labels Sep 11, 2023
@jeff-dude jeff-dude self-assigned this Sep 12, 2023
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR DuneSQL migration and removed ready-for-final-review labels Sep 12, 2023
@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Sep 12, 2023
@jeff-dude jeff-dude merged commit 09ab15c into duneanalytics:main Sep 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
@henrystats henrystats deleted the flashloans-aave branch September 13, 2023 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants