Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tigris Perpetual Contracts - Easy - Ready for review #4148

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

henrystats
Copy link
Contributor

Thank you for contributing to Spellbook!

Please refer to the top of the readme in the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.

@dune-eng
Copy link

Workflow run id 5954848769 approved.

@dune-eng
Copy link

Workflow run id 5954848859 approved.

@dune-eng
Copy link

Workflow run id 5954955290 approved.

@dune-eng
Copy link

Workflow run id 5954955492 approved.

@dune-eng
Copy link

Workflow run id 5955115938 approved.

@dune-eng
Copy link

Workflow run id 5955116116 approved.

@dune-eng
Copy link

Workflow run id 5955343419 approved.

@dune-eng
Copy link

Workflow run id 5955343318 approved.

@henrystats henrystats changed the title New Tigris Perpetual Contracts New Tigris Perpetual Contracts - Easy - Ready for review Aug 23, 2023
@henrystats
Copy link
Contributor Author

@jeff-dude this pr adds new sources for tigris contracts (new contracts were launched today), there was rewrite of the code itself just plugged in the new trading contract sources soo it'd be easy to review...

I removed an inner join in the options model as well but overall there's no changes to schema, or the sql of the spells so this should be quick to review... trying to get this merged early as the dashboard relies on the spell.. and trades will now only happen on the new contracts.

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, looks good!

@jeff-dude jeff-dude merged commit 9852556 into duneanalytics:main Aug 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@henrystats henrystats deleted the new-trading-contracts branch August 24, 2023 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants