-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tigris Perpetual Contracts - Easy - Ready for review #4148
New Tigris Perpetual Contracts - Easy - Ready for review #4148
Conversation
Workflow run id 5954848769 approved. |
Workflow run id 5954848859 approved. |
Workflow run id 5954955290 approved. |
Workflow run id 5954955492 approved. |
Workflow run id 5955115938 approved. |
Workflow run id 5955116116 approved. |
Workflow run id 5955343419 approved. |
Workflow run id 5955343318 approved. |
@jeff-dude this pr adds new sources for tigris contracts (new contracts were launched today), there was rewrite of the code itself just plugged in the new trading contract sources soo it'd be easy to review... I removed an inner join in the options model as well but overall there's no changes to schema, or the sql of the spells so this should be quick to review... trying to get this merged early as the dashboard relies on the spell.. and trades will now only happen on the new contracts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem, looks good!
Thank you for contributing to Spellbook!
Please refer to the top of the
readme
in the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.