-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Optimism Bridge Flows - Ready for review #4130
Migrate Optimism Bridge Flows - Ready for review #4130
Conversation
Workflow run id 5918029859 approved. |
Workflow run id 5918029936 approved. |
Workflow run id 5919785506 approved. |
Workflow run id 5919785490 approved. |
Workflow run id 5919801973 approved. |
Workflow run id 5919802016 approved. |
Workflow run id 5919815364 approved. |
Workflow run id 5919815312 approved. |
Workflow run id 5919909370 approved. |
Workflow run id 5919909338 approved. |
Workflow run id 5919950534 approved. |
Workflow run id 5919950576 approved. |
Workflow run id 5920329715 approved. |
Workflow run id 5920329621 approved. |
@chuxinh wanted to tag you to this as well incase you wanted to review... migrated the bridge flows spell and the spells that it relied on... tested it on dune.com that it works correctly as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits. Otherwise LGTM!
@@ -27,7 +29,7 @@ WITH bridge_events AS ( | |||
recipient_address, | |||
trace_address, a.evt_index, | |||
project_contract_address, | |||
COALESCE(message_nonce_hash,'unknown') AS transfer_id, | |||
message_nonce_hash AS transfer_id, -- removing the coalesce since this isn;t a unique key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message_nonce_hash AS transfer_id, -- removing the coalesce since this isn;t a unique key | |
message_nonce_hash AS transfer_id, -- removing the coalesce since this isn't a unique key |
- &block_month | ||
name: block_month | ||
description: Month of the block time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add extra line
) a ("name","chain","nativeCurrency","chainId","networkId","infoURL","explorer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add extra line
- &block_month | ||
name: block_month | ||
description: Month of the block time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add extra line
DENSE_RANK() OVER (PARTITION BY evt_tx_hash ORDER BY evt_index ASC) AS msg_index | ||
|
||
FROM {{ source ('ovm_optimism', 'L2CrossDomainMessenger_evt_RelayedMessage') }} | ||
{% if is_incremental() %} | ||
WHERE evt_block_time >= (NOW() - interval '14 days') | ||
WHERE evt_block_time >= (NOW() - interval '14' Day) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a line below
Workflow run id 5967873954 approved. |
Workflow run id 5967874167 approved. |
Workflow run id 5967877005 approved. |
Workflow run id 5967876904 approved. |
changes made @chuxinh |
@jeff-dude the Wallet summary spell relies on this getting merged first so I could add bridged funds to it... This bridge flows spell is ready for review / merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment below
Workflow run id 5978038627 approved. |
Workflow run id 5978038566 approved. |
Workflow run id 5978449540 approved. |
Workflow run id 5978449679 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Thank you for contributing to Spellbook!
Please refer to the top of the
readme
in the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.