Dex trades beta dunesql #4107
Merged
Dex trades beta dunesql #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, you'll just have to comment out refs which aren't migrated yet (and likely the jinja comment, based on bug we found) |
4678934 to
cbd541c
Compare
jeff-dude
reviewed
Aug 18, 2023
| {{ config( | ||
| tags=['dunesql'], | ||
| alias = alias('trades_migration_beta'), | ||
| partition_by = ['block_date'], |
There was a problem hiding this comment.
block_month here to match pattern of upstream spells?
jeff-dude
approved these changes
Aug 18, 2023
|
Good catch changed to |
antonio-mendes
approved these changes
Aug 18, 2023
|
This can't be merged until |
This was referenced Aug 18, 2023
bd42df1 to
c485e01
Compare
527efb7 to
c32ecb8
Compare
Closed
couralex6
approved these changes
Aug 21, 2023
|
I figured out the issue! The incremental part of statement was incorrectly formated due to the loop, so the last model didn't have the time filter (fixed in b29627f) . This was not a problem before but since I added the |
jeff-dude
approved these changes
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to test dex trades under the alias
trades_migration_betato make sure that everything builds correctly and to check the data.