DuneSQL Migration: balancer_trades
#4097
Conversation
|
Workflow run id 5939536845 approved. |
|
Workflow run id 5939536837 approved. |
|
Workflow run id 5940499252 approved. |
|
Workflow run id 5940499245 approved. |
|
Workflow run id 5940849200 approved. |
|
Workflow run id 5940849176 approved. |
|
Workflow run id 5944453683 approved. |
|
Workflow run id 5944453841 approved. |
| swap.poolId AS pool_id, | ||
| swap_fees.swap_fee_percentage / POWER(10, 18) AS swap_fee, | ||
| swap.evt_tx_hash AS tx_hash, | ||
| '' AS trace_address, |
There was a problem hiding this comment.
we are deprecating this field from downstream dex.trades, so it can be removed from all balancer spells
if you'd prefer to take note and remove when you revisit these to update the varbinary types, that works too, then we can just ignore the field downstream. if you want to do now, that is good too
There was a problem hiding this comment.
it can be removed from unique key, unique combo test in schema files, and all throughout spells in the PR
There was a problem hiding this comment.
So trace_address can be removed from everywhere and we will be fine to merge? We won't have to wait additional time to merge?
There was a problem hiding this comment.
i will plan to merge tomorrow morning. if you have time to remove those fields before, please do. if not, please plan to do on your follow up PR to clean out data types and such
There was a problem hiding this comment.
I will do it on the follow up PR. Thank you.
|
Workflow run id 5944723708 approved. |
|
Workflow run id 5944723914 approved. |
|
Workflow run id 5945022170 approved. |
|
Workflow run id 5945022167 approved. |
Thank you for contributing to Spellbook!
Please refer to the top of the
readmein the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.