Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY TO REVIEW] Add kyberswap aggregator #4070

Merged
merged 32 commits into from
Aug 24, 2023
Merged

[READY TO REVIEW] Add kyberswap aggregator #4070

merged 32 commits into from
Aug 24, 2023

Conversation

nhd98z
Copy link
Contributor

@nhd98z nhd98z commented Aug 14, 2023

Thank you for contributing to Spellbook!

Please refer to the top of the readme in the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.

@dune-eng
Copy link

Workflow run id 5851425320 approved.

@dune-eng
Copy link

Workflow run id 5851425404 approved.

@dune-eng
Copy link

Workflow run id 5851511286 approved.

@dune-eng
Copy link

Workflow run id 5851511283 approved.

@dune-eng
Copy link

Workflow run id 5851565929 approved.

@dune-eng
Copy link

Workflow run id 5851566019 approved.

@dune-eng
Copy link

Workflow run id 5851618254 approved.

@dune-eng
Copy link

Workflow run id 5851618315 approved.

@dune-eng
Copy link

Workflow run id 5851675200 approved.

@dune-eng
Copy link

Workflow run id 5851675098 approved.

@dune-eng
Copy link

Workflow run id 5851801753 approved.

@dune-eng
Copy link

Workflow run id 5851801918 approved.

@dune-eng
Copy link

Workflow run id 5851863407 approved.

@dune-eng
Copy link

Workflow run id 5851863527 approved.

@nhd98z nhd98z force-pushed the kyberswap-aggregator branch from 1ba48ee to 8d4eba2 Compare August 14, 2023 04:32
@dune-eng
Copy link

Workflow run id 5851871926 approved.

@dune-eng
Copy link

Workflow run id 5851871862 approved.

@nhd98z nhd98z force-pushed the kyberswap-aggregator branch from 8d4eba2 to 6474b7a Compare August 14, 2023 04:34
@dune-eng
Copy link

Workflow run id 5851884696 approved.

@nhd98z nhd98z force-pushed the kyberswap-aggregator branch 2 times, most recently from 00127d8 to 586fac7 Compare August 14, 2023 04:36
@dune-eng
Copy link

Workflow run id 5851893469 approved.

@dune-eng
Copy link

Workflow run id 5851893421 approved.

@nhd98z nhd98z force-pushed the kyberswap-aggregator branch from 586fac7 to 8ccf8ba Compare August 14, 2023 04:37
@dune-eng
Copy link

Workflow run id 5851899018 approved.

@dune-eng
Copy link

Workflow run id 5851899033 approved.

@dune-eng
Copy link

Workflow run id 5852023026 approved.

@dune-eng
Copy link

Workflow run id 5852023166 approved.

@nhd98z nhd98z force-pushed the kyberswap-aggregator branch from abab76d to 64f9cff Compare August 14, 2023 05:04
@dune-eng
Copy link

Workflow run id 5852034378 approved.

@nhd98z nhd98z force-pushed the kyberswap-aggregator branch from 5092d17 to 6e2735f Compare August 24, 2023 03:42
@dune-eng
Copy link

Workflow run id 5959197483 approved.

@dune-eng
Copy link

Workflow run id 5959197588 approved.

@dune-eng
Copy link

Workflow run id 5959247340 approved.

@dune-eng
Copy link

Workflow run id 5959247455 approved.

@dune-eng
Copy link

Workflow run id 5959268092 approved.

@dune-eng
Copy link

Workflow run id 5959268135 approved.

@nhd98z
Copy link
Contributor Author

nhd98z commented Aug 24, 2023

@Hosuke @jeff-dude I've updated schema and table names.

Hosuke
Hosuke reviewed Aug 24, 2023
View reviewed changes
models/kyberswap/kyberswap_aggregator_trades.sql Outdated
{{ config
(
tags=['dunesql'],
alias = alias('aggregator_trades'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe kyberswap_aggregator.trades

Suggested change
alias = alias('aggregator_trades'),
schema = 'kyberswap_aggregator',
alias = alias('trades'),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@dune-eng
Copy link

Workflow run id 5961913062 approved.

@dune-eng
Copy link

Workflow run id 5961913182 approved.

@dune-eng
Copy link

Workflow run id 5961990792 approved.

@dune-eng
Copy link

Workflow run id 5961990954 approved.

jeff-dude
jeff-dude approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again for the first time contribution!

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Aug 24, 2023
@jeff-dude jeff-dude merged commit 3b105d1 into duneanalytics:main Aug 24, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Aug 24, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Dune Contributor:

GitPOAP: 2023 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hosuke Hosuke Hosuke approved these changes

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nhd98z @dune-eng @Hosuke @jeff-dude