Add base safes #3827
Merged
Add base safes #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spells implemented are: safe_celo_safes.sql safe_celo_singletons.sql safe_celo_transactions.sql safe_celo_celo_transafers.sql Source implemented is safe_celo_sources.yml Schema implemented is safe_celo_schema.yml
schema property follows format project_version_blockchain, e.g. safe_celo
Hosuke
reviewed
Aug 24, 2023
Hosuke
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
LGTM.✅
Thank you @danielpartida
- Partition by block_month ✅
- Dummy legacy models added for new spells ✅
Sample safe_base_safes
Sample safe_base_transactions
Sample safe_base_eth_transfers
|
You are a rockstar @Hosuke ! LFG! |
|
Do you see any additional blockers @Hosuke |
I will pass to Jeff for the final review. |
|
@jeff-dude let me know if further input is necessary from my end |
jeff-dude
approved these changes
Aug 24, 2023
all is good, getting a batch together to merge now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook!
Please refer to the top of the
readmein the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.