-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poly, arb, and bnb xchange dex trades models and include xchange trades in dex.trades #3576
Conversation
Workflow run id 5315198991 approved. |
Workflow run id 5315198995 approved. |
Workflow run id 5315409483 approved. |
Workflow run id 5315409482 approved. |
Workflow run id 5315608357 approved. |
Workflow run id 5315608355 approved. |
Ethereum trades added to dex_trades_seed and tests have passed. Test results for other chains (poly, arb, bnb) look good other than missing tokens, which will be added in this PR: Let me know if you have any questions or comments. |
ethereum,xchange,1,2023-06-04,0xb9cf9af8c09ee4b01f7998e4d09b5732e3d59db577453d8f649c3368a5be4723,3,0x7102dc82ef61bfb0410b1b1bf8ea74575bf0a105,16740.414870869491102082,0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2,349.842891200744390656 | ||
ethereum,xchange,1,2023-06-04,0xdca9e79f3d41644b579994c0e62f73e8741605b85bb9a80fcc6d173180fd891c,26,0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2,264.386114548212846651,0x7103ebdbf1f89be2d53eff9b3cf996c9e775c105,16740.857191421503408067 | ||
ethereum,xchange,1,2023-06-12,0xf71d8fd364e2402eb11ba7bfbd9b59336e2b075571c1523d119f74a11a1986e3,170,0x117546d1467d80c6bde13910412c724383260cf9,345579.7727468311529198,0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2,0.1 | ||
ethereum,xchange,1,2023-06-12,0x7da422240ab88976df8c9694114daf8b8cfc335e1f851a8c175bca99e5e4cdcd,200,0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2,0.134508790612232095,0x117546d1467d80c6bde13910412c724383260cf9,477750.8030874053723140 | ||
ethereum,xchange,1,2023-06-12,0x4eba2bbed2a473a3a6b2fbfc1d784940b5157afc285c35aff1200e491ea1346a,115,0xdbc7945c5403c589ec39a9aa8c5af234c706f6a2,14049529527.028758241707276441,0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2,0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mike-x7f,
seems currently this file only contains seed records for the ethereum
chain.
Do you want to add xchange seeds for other chains as well?
Like for [bnb, arbitrum, polygon] chains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could add some but that test requires both the bought and sold tokens to be in the tokens.erc20 table in order to get the bought and sold amounts. Xchange is a new DEX and doesn't have a lot of volume on those chains yet, and all of the trades so far involve at least one token that isn't in tokens.erc20 yet. I am adding tokens to tokens.erc20 in this PR so I can use check_dex_seed, but I think it will fail until those tokens are added. I ran a manual test on those chains that you can find in the link in my other comment. All of the fields are populated as expected except for those that require tokens.erc20 data (symbol, pair, bought/sold amount).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can approve with the current state. thanks again @mike-x7f
Thank you Jeff! |
…trades in dex.trades (duneanalytics#3576) * add poly, bnb, arb chains and xchange trades main * add check_dex_seed tests * convert to lowercase and add tokens for test --------- Co-authored-by: Mike X7F <@m1k3x7f>
Brief comments on the purpose of your changes:
For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Pricing checks:
coin_id
represents the ID of the coin on coinpaprika.comJoin logic:
Incremental logic: