-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Airdrop Schema, Clean up OP Drop 1, Init OP Token Data #2622
Conversation
Workflow run id 4093189292 approved. |
Workflow run id 4093189293 approved. |
Workflow run id 4093433004 approved. |
Workflow run id 4093433003 approved. |
Workflow run id 4094161489 approved. |
Workflow run id 4094161491 approved. |
Workflow run id 4094186549 approved. |
Workflow run id 4094186548 approved. |
Workflow run id 4094211780 approved. |
Workflow run id 4094211778 approved. |
Workflow run id 4094217459 approved. |
Workflow run id 4094217445 approved. |
Workflow run id 4096964120 approved. |
Workflow run id 4096964118 approved. |
Workflow run id 4097008045 approved. |
Workflow run id 4097008043 approved. |
Workflow run id 4367116542 approved. |
Workflow run id 4367099481 approved. |
Workflow run id 4367341283 approved. |
Workflow run id 4367341290 approved. |
bumping this + there's also the op airdrop #2 address list which was too large to put in a table: https://github.com/ethereum-optimism/op-analytics/blob/main/reference_data/address_lists/op_airdrop2_addresses.csv |
Workflow run id 4443507915 approved. |
Workflow run id 4443507912 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as for large files, are you in contact with niles and ingest team for their upload process? that may be best, cc @nileslawrence |
@MSilb7 can you help me understand the intention of this airdrop spell better?
i wonder if these all make sense to be tables, rather than incremental? and if there is an end date, a i also thought maybe the intention was to be tracking the airdrop transfers over time, but the inner join to |
Workflow run id 4492031679 approved. |
Workflow run id 4492031689 approved. |
Workflow run id 4500579524 approved. |
Workflow run id 4500579511 approved. |
closing this, can track in tagged PRs |
Brief comments on the purpose of your changes:
Cleaning up some naming & methodologies around OP Airdrop #1, adding basic token metadata for tracking, and initializing a generalized airdrop schema.
Note: There may be some downstream implications for how OP Airdrop 1 tables are named, they should've specified drop 1, ideally something like
airdrop.op_airdrop_1_addresses
.Open to other schema-type modifications, since these things can happen on any chain.
Edit Feb 11 - This sprawled a bit, but also trying to unify the scattered OP-related folders within an 'OP' folder.
Side-Note: I wonder if there's some generic inputs we can set up for the
MerkleClaim
fork airdrop contracts (i.e. give the table name, field name for claimer, field name for amount, token address & that automatically populates the spell).For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Pricing checks:
coin_id
represents the ID of the coin on coinpaprika.comJoin logic:
Incremental logic: