-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] Statamic 5 #1039
Merged
Merged
[7.x] Statamic 5 #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statamic 5 drops the dependency on `laravel/helpers`, where this helper was coming from. Swapped out for `Arr::pull()`
…merce into statamic-5
The `doctrine/dbal` package was removed in Laravel 11, which meant the `getDoctrineSchemaManager` method was removed. Instead, we can use `Schema::getColumns()` from laravel/framework#49020 , which was released in Laravel 10.34.
…merce into statamic-5
This reverts commit 22defdb.
Released as part of v7.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the necessary changes required to support Statamic 5.
This PR will be added to as time goes on.
Changes
composer.json
dev-master
for now. Once v5 has been released, it can be changed to^5.0
.laravel/helpers
functionslaravel/helpers
dependency, which provided backwards compatibility for old string/array helpers.Str
class.TestCase
TestCase
for addons statamic/cms#9573.SendConfiguredNotifications
Antlers::parser()
instead.doctrine/dbal
dependency but it provided alternative methods for everything it was providing, so we've adjusted our code to use it.To Do
composer.json
& testing matrix to released versions, rather thandev-*
versions.