Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STAY-2408] feat: add deposit type to stays payment type #999

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

SamHutchings
Copy link
Contributor

Context

We are starting to offer deposit rates via the Stays API. We are not yet finished with our implementation, waiting on details from Travelport around how we can show this data in a structured way. However, to unblock some customers and gather some data on what these rates look like, we are going to allow booking these rates.

We aren't adding support for booking these via the dashboard yet, but once booked both Duffel and other dashboard users will need to view the booking details, so we need to add this type to add a new price breakdown component for deposit type rates.

Implementation

  • Add deposit to the payment types type.

@SamHutchings SamHutchings requested a review from a team as a code owner January 29, 2025 09:47
package.json Outdated Show resolved Hide resolved
igorp1
igorp1 previously approved these changes Jan 29, 2025
Copy link
Contributor

@igorp1 igorp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the version change, LGTM!

src/Stays/StaysTypes.ts Outdated Show resolved Hide resolved
@igorp1 igorp1 self-requested a review January 29, 2025 09:53
@SamHutchings SamHutchings force-pushed the add-deposit-rate branch 2 times, most recently from d175296 to 259e603 Compare January 29, 2025 18:01
@SamHutchings SamHutchings requested a review from jekku January 29, 2025 18:01
@SamHutchings
Copy link
Contributor Author

@jekku @igorp1 i've updated to export the type rather than it living in the rate, and i've also made a couple of other updates.

Copy link
Contributor

@jekku jekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enum re-ordering gives me a massive sense of relief. ☺️

@SamHutchings SamHutchings merged commit 294c7c9 into main Jan 30, 2025
4 checks passed
@SamHutchings SamHutchings deleted the add-deposit-rate branch January 30, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants