Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types #968

Merged
merged 13 commits into from
Oct 10, 2024
2 changes: 1 addition & 1 deletion src/booking/Offers/OfferTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ export interface OfferSlice {
* - `"4"`: premium seating, additional legroom and recline. Situated in business class or higher.
* - `"5"`: deluxe seating, additional legroom and reclines to lie flat position. Situated in business class or higher.
*/
ngs_shelf: number
ngs_shelf: number | null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

export interface OfferSliceSegment {
Expand Down
11 changes: 5 additions & 6 deletions src/types/shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export type FlightsConditions = {
* If any of the slices on the order or offer can't be refunded then the `allowed` property will be `false`.
* If the airline hasn't provided any information about whether this order or offer can be refunded then this property will be `null`.
*/
refund_before_departure?: FlightsCondition | null
refund_before_departure: FlightsCondition | null

/**
* Whether the whole order or offer can be changed before the departure of the first slice.
Expand All @@ -147,7 +147,7 @@ export type FlightsConditions = {
* In this case you should refer to the slices conditions to determine if any part of the order or offer is changeable.
* If the airline hasn't provided any information about whether this order or offer can be changed then this property will be `null`.
*/
change_before_departure?: FlightsCondition | null
change_before_departure: FlightsCondition | null
}

/**
Expand All @@ -162,21 +162,20 @@ export type FlightsConditions = {
* passengers if you require this level of granularity.
*/
export type OfferSliceConditions = FlightsConditions & {
// TODO: ask James about this
/**
* Whether passengers are able to select a seat prior to check in.
*/
advance_seat_selection: boolean
advance_seat_selection: boolean | null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/**
* Whether passengers are given preferential boarding over others passengers in their cabin.
*/
priority_boarding: boolean
priority_boarding: boolean | null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/**
* Whether passengers are given access to a fast track lane during check in.
*/
priority_check_in: boolean
priority_check_in: boolean | null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

/**
Expand Down