-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing types #968
Merged
+473
−550
Merged
Add missing types #968
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9c80253
feat: add OrderCancellationAirlineCredit
andrejak 455de1b
feat: copy travel agent ticket from dashboard
andrejak d89060f
feat: add paid at to order payment status
andrejak bf6a49a
fix: fixes more types
igorp1 b1abcf6
feat: add airline credits as a refund option
andrejak 33c495c
fix: fix order change types
andrejak 04920bf
fix: add email and phone number to passenger
andrejak a5b675e
fix: add missing passenger IDs to order document
andrejak d7c4ce3
fix: update tests with type changes
andrejak 6fc6143
fix: lint
andrejak c2c6c13
fix: nullable conditions
andrejak 956bfd5
fix: add description for travel agent ticket
andrejak 72ce238
fix: add missing nullable condition
andrejak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,7 +137,7 @@ export type FlightsConditions = { | |
* If any of the slices on the order or offer can't be refunded then the `allowed` property will be `false`. | ||
* If the airline hasn't provided any information about whether this order or offer can be refunded then this property will be `null`. | ||
*/ | ||
refund_before_departure?: FlightsCondition | null | ||
refund_before_departure: FlightsCondition | null | ||
|
||
/** | ||
* Whether the whole order or offer can be changed before the departure of the first slice. | ||
|
@@ -147,7 +147,7 @@ export type FlightsConditions = { | |
* In this case you should refer to the slices conditions to determine if any part of the order or offer is changeable. | ||
* If the airline hasn't provided any information about whether this order or offer can be changed then this property will be `null`. | ||
*/ | ||
change_before_departure?: FlightsCondition | null | ||
change_before_departure: FlightsCondition | null | ||
} | ||
|
||
/** | ||
|
@@ -162,21 +162,20 @@ export type FlightsConditions = { | |
* passengers if you require this level of granularity. | ||
*/ | ||
export type OfferSliceConditions = FlightsConditions & { | ||
// TODO: ask James about this | ||
/** | ||
* Whether passengers are able to select a seat prior to check in. | ||
*/ | ||
advance_seat_selection: boolean | ||
advance_seat_selection: boolean | null | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
/** | ||
* Whether passengers are given preferential boarding over others passengers in their cabin. | ||
*/ | ||
priority_boarding: boolean | ||
priority_boarding: boolean | null | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
/** | ||
* Whether passengers are given access to a fast track lane during check in. | ||
*/ | ||
priority_check_in: boolean | ||
priority_check_in: boolean | null | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
/** | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://duffel.com/docs/api/v2/offers#offers-schema-slices-slices-ngs-shelf